The method works fine, but Judge doesn't accept it.

Question about the task

Resolved

Hi guys, I made the method workable, and it outputs precisely what it should, but the Judge doesn't accept my solution. My assumption is this is because of

try-catch

block, so fine, but can anyone give me a hint on what should I focus on to resolve it correctly? Thank you in advance!

package en.codegym.task.pro.task16.task1601; import com.sun.source.tree.TryTree; import java.time.DateTimeException; import java.time.DayOfWeek; import java.util.Date; /* Just not on Monday :) */ public class Solution { static Date birthDate = new Date(86, 02, 10); public static void main(String[] args) { System.out.println(getDayOfWeek(birthDate)); } static String getDayOfWeek(Date date) { int day = date.getDay(); try { DayOfWeek dayOfWeek = DayOfWeek.of(day); return String.valueOf(dayOfWeek); } catch (DateTimeException e){ } return "SUNDAY"; } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Thomas

Level 41 , Bayreuth, Germany

29 September 2022, 16:51

solution

have you tried lowercase and/ or first letter capitalized? (The tasks name is 'Just not on Monday :) ' ... ) If that's not the problem and it really is the try-catch then a) don't return a made up value if anything goes wrong. Better rethrow a RuntimeException. But that can't be the problem I believe (Better would be to handle the exception in main. But I doubt they accept modifying the methods signature?) b) use switch-case instead of DayOfWeek.of() or use LocalDate.format() ... but that's rather complex to get the LocalDate of a date

LocalDate ld = date.toInstant().atZone(ZoneId.systemDefault()).toLocalDate();
// first letter is already uppercase, you can use toLowerCase() or toUpperCase() on the result before you return it
return ld.format(DateTimeFormatter.ofPattern("EEEE").withLocale(Locale.ENGLISH));

Alex Tor Software Developer

30 September 2022, 14:02

Hi Thomas :) String format wasn't the case, so the

return String.valueOf(dayOfWeek);

returned uppercased names of the weeks, therefore I declared it "SUNDAY" in catch block, it was a wrong solution though. switch-case was the solution, task was resolved. Best regards, man!

Thomas

Level 41 , Bayreuth, Germany

30 September 2022, 16:05

Bahh... I'm so dumb... instead of using the DayOfWeek.of() that may throw an exception you just could use the enums build in possibilities like the values array. That does not throw catched exceptions (just an ArrayIndexOutOfBoundsException but that's a RuntimeException that you do not need to catch). Then you just need to adapt the day of week int value to the way DayOfWeeks is using it and voila ;)

// numbering of day of week vals used by the diff classes/ enums
// DayOfWeek 0=Monday, 1=Tuesday...
// Date.getDay 0=Sunday, 1=Monday,
// Calendar.DAY_OF_WEEK 1=Sunday, 2=Monday ... 7=Saturday

// a sample date
Date date = new Date(2022 - 1900, Calendar.SEPTEMBER, 30);
System.out.println(date);

// using Date.getDay() [deprecated]
// see above we need to deduct 1 to get the DayOfWeek way of numbering... to avoid neg vals we instead add 6
// and use a modulus 7 afterwards
DayOfWeek dayOfWeek = DayOfWeek.values()[(date.getDay() + 6) % 7];
System.out.println(dayOfWeek);

// if you want to use Calendar, create an instance and set it to the Dates value
Calendar cal = Calendar.getInstance();
cal.setTime(date);
int dowNum = cal.get(Calendar.DAY_OF_WEEK); // now get the weekday as int, see above, again numbered differently
// the way to convert the num is similar to above
DayOfWeek dowFromCal = DayOfWeek.values()[(dowNum + 5) % 7];
System.out.println(dowFromCal);

// the LocalDate way I already described in my other post
System.out.println(date.toInstant().atZone(ZoneId.systemDefault()).toLocalDate().getDayOfWeek());  // .getDisplayName() after getDayOfWeek() can be used to localize

Most of Date is deprecated but still used a lot at CG. LocalDate (LocalDateTime) is the Java 8+ replacement and the way to go now, 2nd choice would be Calendar.

Thomas

Level 41 , Bayreuth, Germany

30 September 2022, 16:14

An, if you're interested in some LocalDate examples (LocalDateTime works similar)...

// output the current date, default formatting
System.out.println(
        LocalDate.now() // LocalDate
);

// output some specific date
System.out.println(
        LocalDate.of(2001, Month.MAY, 15)
);

// now use an output formatter (output weekday and full month name) and US locale of current date
System.out.println(
        LocalDate.now() // current date, a LocalDate
                .format(DateTimeFormatter // returns a String
                        .ofLocalizedDate(FormatStyle.FULL)
                        .withLocale(Locale.US)
                )
);

// same as above but set a specific day and default locale, change the format style from full to long (no weekday)
System.out.println(
        LocalDate.of(1999, Month.FEBRUARY, 21) // LocalDate
                .format(DateTimeFormatter // String
                        .ofLocalizedDate(FormatStyle.LONG)
                )
);

// use time zones in LocalDateTime, source is current date and time in Berlin and output New York time,
// use a custom pattern to format the output
System.out.println(
        LocalDateTime
                .now() // LocalDateTime
                .atZone(ZoneId.of("Europe/Berlin")) // ZoneDateTime
                .format(DateTimeFormatter // String
                        .ofPattern("dd. MMMM yy, HH:mm:ss")
                        .withZone(ZoneId.of("America/New_York"))
                        .withLocale(Locale.GERMANY)
                )
);

pretty neat ;)