Help needed

Question about the task

Resolved

Hey, guys! Maybe, someone could help me out with this. This code returns a correct solution for all mentioned examples ("a" tag, nested tags), but still doesn't verify. Guess, I'm missing some variant of an input file. Thanks!

Read from the console the name of a file containing HTML.

Example:
Info about Leela Leela Turanga
Supergirl

The main method's first parameter is a tag name. For example, "span".
Display all tags that match the specified tag.
The order should match their order in the file, each tag on a new line.
The number of spaces, newline characters (\n), or carriage returns (\r) does not affect the result.
The file does not have a CDATA tag. Each opening tag has a separate closing tag, and there are no self-closing tags.
Tags may have nested tags.

Example output:
Leela Turanga Leela Turanga Super girl

Tag templates:
<tag>text1</tag> <tag text2>text1</tag> <tag text2>text1</tag>

text1 and text2 can be empty

Requirements:

The program must read the file name from the console (use BufferedReader).
The BufferedReader used for reading input from the console must be closed after use.
The program must read the file's contents (use FileReader).
The file input stream (FileReader) must be closed.
The program must write to the console all the tags that match the tag specified by the argument passed to the main method.

package com.codegym.task.task19.task1918; import java.io.*; import java.util.Arrays; import java.util.List; import java.util.ArrayList; /* Introducing tags */ public class Solution { //public static List<String> res = new ArrayList<>(); public static void main(String[] args) throws IOException { BufferedReader myInput = new BufferedReader(new InputStreamReader(System.in)); String fileName = myInput.readLine(); //String fileName = "h:\\file1.txt"; myInput.close(); BufferedReader myFile = new BufferedReader (new FileReader(fileName)); String[] res = new String[100]; String interim = ""; char ongoing; int openedTags = 0, closedTags = 0; boolean startWrite = false; boolean[] resWrite = new boolean[100]; while (myFile.ready()) { ongoing = (char) myFile.read(); if (ongoing == '<') startWrite = true; if (startWrite) interim += ongoing; if (interim.equals("<" + args[0])) { res[openedTags] = ""; res[openedTags] += interim.substring(0,interim.length()-1); resWrite[openedTags] = true; interim = ""; openedTags += 1; startWrite = false; } for (int i = 0; i < openedTags; i++) { if (resWrite[i]) res[i] += ongoing; } if (interim.equals("</" + args[0] + ">")) { closedTags += 1; resWrite[openedTags-closedTags] = false; if (openedTags - closedTags == 0) closedTags = 0; } if (!interim.equals("<" + args[0]) & ongoing == '>') { interim = ""; startWrite = false; } } //System.out.println(Arrays.toString(res)); for (int i = 0; i < res.length; i++) { if (res[i] != null) { res[i] = res[i].replaceAll("\r\n",""); System.out.println(res[i]); } } myFile.close(); } }

Comments (6)

Popular
New
Old

You must be signed in to leave a comment

Nikita Petrov Controls engineer

3 December 2022, 14:39

Finally I made it, thakts to the Thomas' example (see it above). CGM correct output for it is:

[span][b][span]Leela Turanga[/span][span]the[/span][/b][/span]
[span]Leela Turanga[/span][span]the[/span]

[span]Super[/span]
[span]girl[/span]

And the output for a verified solution is:

[span][b][span]Leela Turanga[/span][span]the[/span][/b][/span]
[span]Leela Turanga[/span][span]the[/span]
[span]the[/span]
[span]Super[/span]
[span]girl[/span]

which makes more sense, as for me. Thomas, thanks again for the tip.

Thomas

Level 41 , Bayreuth, Germany

26 November 2022, 15:56

If I test the given example (the one with span) the output of your code is different to CodeGym's example output.

Nikita Petrov Controls engineer

27 November 2022, 10:39

I appreciate your answer. Could you elaborate on it a bit more? CDG output for a "span" tag: Leela Turanga Leela Turanga Super girl And for the given code it would be: Leela Turanga Leela Turanga Super girl I don't really see any difference. And by the way, is a tag in args[0] given as "span" or as ""?

Thomas

Level 41 , Bayreuth, Germany

27 November 2022, 11:46

nice, that's funny. I copied your code again and now it is working with the default example. Seems something went wrong with some of the copy/ paste. Sorry... But I have enhanced the example for you

Info about Leela [span xml:lang="en" lang="en"][b][span]Leela Turanga
[/span][span]the[/span][/b][/span][span]Super[/span][span]girl[/span]

Your code outputs:

[span][b][span]Leela Turanga[/span][span]the[/span][/b][/span]
[span]Leela Turanga[/span]
[span]the[/span][span]Super[/span][span]girl[/span]
[span]Super[/span]
[span]girl[/span]

expected (at least I think )

[span][b][span]Leela Turanga[/span][span]the[/span][/b][/span]
[span]Leela Turanga[/span]
[span]the[/span]
[span]Super[/span]
[span]girl[/span]

the nesting limit is also questionable. But I do not know how thorough testing is. args is empty by default. You need to set it. In IntelliJ 'Modify Run Configuration' -> 'Program arguments'. Or, if you have set up Java and the environment correctly you can run the program like java Solution span

Nikita Petrov Controls engineer

28 November 2022, 08:24

It's a good call about nesting, thanks, I'll try your example with the correct solution from CDG and look at the output. And about tags - I understand that args[0] is empty, what I meant is whether I should set it as args[0] = "tag" or args[0] = "<tags>" (with angle brackets or no).

Thomas

Level 41 , Bayreuth, Germany

28 November 2022, 10:04

they expect you to pass just "tag" (without angle brackets)