Program is still failing to pass testing ! a Help please

Question about the task

Under discussion

Hi everyBody, the program fails to pass testing, I already did a test on my machine and the program responds to the requirements. Can you please help me ? thanks a lot.

The main method accepts a list of arguments.
The first argument, resultFileName, is the name of the resulting file. The remaining arguments are the names of files for fileNamePart.
Each fileNamePart file is a part of a zip file. You need to unzip the entire file by assembling it from its parts.
Write the unzipped file to resultFileName.
Files inside the archive can be large, e.g. 50MB.
Files inside the archive can have any name.

Example input. The archive has one file named abc.mp3:
C:/result.mp3 C:/pathToTest/test.zip.003 C:/pathToTest/test.zip.001 C:/pathToTest/test.zip.004 C:/pathToTest/test.zip.002

Requirements:

In the main method, you need to create a ZipInputStream for the archive assembled from the file parts. The files are passed as arguments to main, starting with the second argument.
Create a output stream to the file passed as main's first argument. Write the file contents from the archive to the output stream.
The stream used to read from the archive must be closed.
The stream used to write to the file must be closed.

package com.codegym.task.task31.task3106; /* Unzipping a file */ import java.io.*; import java.lang.reflect.Array; import java.util.ArrayList; import java.util.Collections; import java.util.zip.ZipEntry; import java.util.zip.ZipInputStream; public class Solution { public static void main(String[] args) throws IOException { // Create a file if it's not already done File fileResult = new File(args[0]); if (!fileResult.exists()) { fileResult.createNewFile(); } // This ArrayList will contain All the FileInputStream Parts ArrayList<FileInputStream> fileInputStreamList = new ArrayList<FileInputStream>(); // This ArrayList will contain All the names of the file Parts ArrayList<String> fileListPath = new ArrayList<>(); // Add the names of the file Parts to the Arraylist for (String arg : args) { fileListPath.add((arg)); } // Sort the names of the file parts alphabetically Collections.sort(fileListPath); // Create a FileInputStream for every file and add it to the ArrayList of the streams for (String filePath : fileListPath) { fileInputStreamList.add(new FileInputStream(new File(filePath))); } // Create a sequence of InputStream from the list of The FileInputStream above SequenceInputStream sequenceInputStream = new SequenceInputStream(Collections.enumeration(fileInputStreamList)); // Create a ZipInputStream for the archive assembled from the file parts ZipInputStream fileInputStream = new ZipInputStream(sequenceInputStream); // Create an output stream to the file passed as main's first argument OutputStream fileOutputStream = new BufferedOutputStream(new FileOutputStream(fileResult)); ZipEntry zipEntry = null; byte[] buffer = new byte[1024]; int len; while (((zipEntry = fileInputStream.getNextEntry()) != null)) { while ((len = fileInputStream.read(buffer, 0, 1024)) > 0) { fileOutputStream.write(buffer, 0, len); } fileOutputStream.flush(); } // The stream used to read from the archive fileInputStream.close(); // The stream used to write to the file fileOutputStream.close(); sequenceInputStream.close(); } }

Comments (6)

Popular
New
Old

You must be signed in to leave a comment

Thomas

Level 41 , Bayreuth, Germany

8 January 2023, 22:07

I'd try first to not add the resultFileName to the fileListPath list

Coboliste

Level 46 , Casablanca, Morocco

9 January 2023, 18:51

Hi Thomas, I hope you are doing well, thanks for your answer. I replaced :

for (String arg : args)
        {
            fileListPath.add((arg));
        }

fileListPath.addAll(Arrays.asList(args).subList(1, args.length));

You are right, it'st an error but my program is still rejected :( life is hard !

Thomas

Level 41 , Bayreuth, Germany

9 January 2023, 20:47

;) a pity... more thoughts, maybe it helps (I still haven't tested your code). - lines 20-22 are not necessary - maybe do not use a BufferedOutputStream as you already use a byte buffer. - flush the out stream after the inner while loop - just using fileInputStream.read(buffer) will do, too as it uses the entire buffer

Coboliste

Level 46 , Casablanca, Morocco

9 January 2023, 21:35

Thanks again Thomas, I did the changes you suggested, the validator still don't like my program :( sorry to bother you, thanks again for the help.

Thomas

Level 41 , Bayreuth, Germany

9 January 2023, 22:15

wow, OK, I've stripped it a little bit and added try-with-resources

ArrayList<InputStream> fileInputStreamList = new ArrayList<>();
Set<String> fileListPath = new TreeSet<>(Arrays.asList(args).subList(1, args.length));

for (String filePath : fileListPath)
    fileInputStreamList.add(new FileInputStream(filePath));

try (SequenceInputStream sequenceInputStream = new SequenceInputStream(Collections.enumeration(fileInputStreamList));
     ZipInputStream fileInputStream = new ZipInputStream(sequenceInputStream);
     OutputStream fileOutputStream = new FileOutputStream(args[0])) {

    ZipEntry zipEntry;
    byte[] buffer = new byte[1024 * 8];
    int len;

    while (((zipEntry = fileInputStream.getNextEntry()) != null)) {
        while ((len = fileInputStream.read(buffer)) > 0) {
            fileOutputStream.write(buffer, 0, len);
        }
    }
}

I've tested it and it works. Hopefully CG thinks the same ;) And if not... what part is still red?

Coboliste

Level 46 , Casablanca, Morocco

10 January 2023, 21:01

Hi again Thomas, the problem persists but i think it's because of the validator since I'm getting the correct results, it's very strange that the validator told that things weren't done when they are. Thanks again for the help.