What am I doing wrong here?

Question about the task

Under discussion

I can't see what I am doing wrong. Anyone who can help?

package com.codegym.task.task18.task1806; import java.io.FileInputStream; import java.io.FileOutputStream; import java.io.IOException; /* Fix the bugs */ public class Solution { public static void main(String[] args) throws IOException { FileInputStream inputStream = new FileInputStream("c:/data.txt"); // Create a stream to write bytes to a file FileOutputStream outputStream = new FileOutputStream("c:/result.txt"); byte[] buffer = new byte[inputStream.available()]; while (inputStream.available() > 0) { // Read the entire file in one batch int count = inputStream.read(buffer); outputStream.write(buffer, 0, count); } inputStream.close(); outputStream.close(); } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

Thomas

Level 41 , Bayreuth, Germany

26 January, 13:03

just jump to the last sentence... This code makes no sense. If you use a buffer that's the size of the input stream, then it is able to take everything the source contains and

inputStream.read(buffer);
outputStram.write(buffer);

without loop would do. If you use a fixed sized buffer like

byte[] buffer = new byte[4 * 1024];

then the condition for the loop you usually make dependent on the retVal of the read method like

int size;
while ((size = inputStream.read(buffer)) != -1) {

and in the loop you just write the full buffer or, if size is smaller, a part

outputStream.write(buffer, 0, size);

ahhh... while I'm writing this I see that's no loop but an if in the original task setup... it might be, that you just should declare the buffer when there is data to read and not an empty file... means inside the loop and switch back to an if or just making the while an if will do