Verification fails

Question about the task

Archived

I would guess they have some other weird condition to appease like the ending "." that needs to be accounted for but not in the example file data. Anyone know what it is so I can add it?

1. In a static block, initialize map with (number, word) pairs from 0 to 12 inclusive.
For example, (0, "zero"), (1, "one"), (2, "two")
2. Read the file name from the console, and then read the contents of the file.
3. Use map to replace all of the numbers with words.
4. Display the result.
5. Close the streams.

Example file data:
This costs 1 dollar, but this is 12. The variable is called file1. 110 is a number.

Example console output:
This costs one dollar, but this is twelve. The variable is called file1. 110 is a number.

Requirements:

The Solution class must have a public static Map<Integer, String> field called words that is initialized immediately.
The program must read the file name from the console (use BufferedReader).
The BufferedReader used for reading input from the console must be closed after use.
The program must read the file's contents (use FileReader).
The file input stream (FileReader) must be closed.
The program should write all of the lines from the file to the console, but any numbers must be replaced with the corresponding words in map.
The Solution class must have a static block that adds thirteen pairs to map.

package com.codegym.task.task19.task1924; import java.io.BufferedReader; import java.io.FileReader; import java.io.InputStreamReader; import java.util.HashMap; import java.util.Map; /* Replacing numbers */ public class Solution { public static Map<Integer, String> map = new HashMap<Integer, String>(); static { map.put(0, "zero"); map.put(1, "one"); map.put(2, "two"); map.put(3, "three"); map.put(4, "four"); map.put(5, "five"); map.put(6, "six"); map.put(7, "seven"); map.put(8, "eight"); map.put(9, "nine"); map.put(10, "ten"); map.put(11, "eleven"); map.put(12, "twelve"); } public static void main(String[] args) { try { BufferedReader br = new BufferedReader(new InputStreamReader(System.in)); String fileName = br.readLine(); FileReader fr = new FileReader(fileName); BufferedReader br2 = new BufferedReader(fr); while (br2.ready()) { String line = br2.readLine(); String tmpLine = line; if (line.endsWith(".")) { tmpLine = line.substring(0, line.length()-1); } for (String word : tmpLine.split(" ")) { if (word.chars().allMatch( Character::isDigit )) { if (map.keySet().contains(Integer.parseInt(word))) { line = line.replaceFirst(word, map.get(Integer.parseInt(word))); } } } System.out.println(line); } br.close(); fr.close(); br2.close(); } catch (Exception e) { e.printStackTrace(); } } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

4 February 2019, 16:08

There seems to be a bug in your code. I made the text file have multiple sentences on the lines and the output started getting strange. For a text file containing this: This costs 1 dollar, but this is 12. The variable is called file1. This costs 1 dollar, but this is 12. This costs 1 dollar, but this is 12. 110 is a number. The output was: This costs one dollar, but this is twelve. The variable is called fileone. This costs one dollar, but this is twelve. This costs 1 dollar, but this is 12. 110 is a number. You can see errors in the middle line specifically. I can't figure out why file1 was changed to fileone, but the last sentence in the line didn't get touched because line 64 uses replaceFirst so when there are duplicates in the same line this will occur. You should be able to fix this issue by making a String array that is split of line, or tmpLine, outside the loop and then using a for loop instead of a foreach loop. Then you could change the word 'at index' in the line instead of the first word.

jim smith

Level 22 , Cedar Park, United States

4 February 2019, 16:23

I will take a look at this. Yeah when changed the regex to account for the trailing periods on the lines I was pretty uneasy about that. I may go back and see if I can rework that. I thought I was already handling the looping so the replaceFirst would work iteratively but I was pretty lax in setting up different test cases. Thanks for keeping me honest.

Guadalupe Gagnon

Level 37 , Tampa, United States

4 February 2019, 16:29

file1 was not changed when the input matched the example input. I still don't know why file1 was changed to fileone when more sentences were added to that line. It doesn't make sense.

jim smith

Level 22 , Cedar Park, United States

6 February 2019, 16:45

I needed to step through line by line and see that it's picking up the "costs one dollar" and instead of replacing that the replaceFirst is grabbing the 1 from file1. I will look into using an indexOf instead that will should land me in the right spot.

Guadalupe Gagnon

Level 37 , Tampa, United States

6 February 2019, 17:27

I'll share a solve with you I created just now. It's not my original solve, it's about 2/3 the size (I've gotten better at programming since i originally solved). I do this so that you can compare and contrast, use what you like, and maybe even improve it. Check your messages.