Working Correctly With Test Data & Folder, But Barely Verifying Anything

Question about the task

Advanced file search

Java Collections, Level 1, Lesson 2

Under discussion

I think the heading says it all here...

Let's implement a configurable file search within a directory.
Look over the java.nio.file.FileVisitor interface and its superclass's implementation java.nio.file.SimpleFileVisitor.
When searching a file tree using the Files.walkFileTree(Path start, FileVisitor<? super Path> visitor) method,
we use the FileVisitor object to perform the required operations on the found Path objects.

Our search class will be called SearchFileVisitor and will extend SimpleFileVisitor.

You can search using the following criteria:
- a term found in the file name (String);
- a term found in the file's contents (String);
- a maximum or minimum file size (int).
You can specify several criteria at the same time.

I wrote code in main that uses the ready-to-use SearchFileVisitor to search for files. All you have to do is implement it. Simple!
Hint 1: The get... and set... methods are getters and setters. The search class's main logic is performed in the visitFile(Path file, BasicFileAttributes attrs) method.
Hint 2: Only use classes from the java.nio package to work with files.

Requirements:

In the SearchFileVisitor class, you need to create partOfName, partOfContent, minSize, and maxSize fields, as well as the corresponding setters.
In the SearchFileVisitor class, you need to create a foundFiles field and a corresponding getter. The field must be initialized immediately.
If a partOfName search criterion is passed to SearchFileVisitor, the visitFile method must add the file to foundFiles if the name contains the value of partOfName.
If a partOfContent search criterion is passed to SearchFileVisitor, the visitFile method must add the file to foundFiles if the file's contents contain the value of partOfContent.
If a maxSize search criterion is passed to SearchFileVisitor, the visitFile method must add the file to foundFiles if the file size is less than maxSize.
If a minSize search criterion is passed to SearchFileVisitor, the visitFile method must add the file to foundFiles if the file size is greater than minSize.
The visitFile method's implementation must allow for several search criteria to be passed at the same time.

package com.codegym.task.task31.task3111; import java.io.IOException; import java.nio.file.Files; import java.nio.file.Path; import java.nio.file.Paths; import java.util.List; /* Advanced file search When searching a file tree using the Files.walkFileTree(Path start, FileVisitor<? super Path> visitor) method, we use the FileVisitor object to perform the required operations on the found Path objects. Our search class will be called SearchFileVisitor and will extend SimpleFileVisitor. You can search using the following criteria: - a term found in the file name (String); - a term found in the file's contents (String); - a maximum or minimum file size (int). You can specify several criteria at the same time. I wrote code in main that uses the ready-to-use SearchFileVisitor to search for files. All you have to do is implement it. Simple! Hint 1: The get... and set... methods are getters and setters. The search class's main logic is performed in the visitFile(Path file, BasicFileAttributes attrs) method. Hint 2: Only use classes from the java.nio package to work with files. Requirements: 4. If a partOfContent search criterion is passed to SearchFileVisitor, the visitFile method must add the file to foundFiles if the file's contents contain the value of partOfContent. 5. If a maxSize search criterion is passed to SearchFileVisitor, the visitFile method must add the file to foundFiles if the file size is less than maxSize. 6. If a minSize search criterion is passed to SearchFileVisitor, the visitFile method must add the file to foundFiles if the file size is greater than minSize. 7. The visitFile method's implementation must allow for several search criteria to be passed at the same time. */ public class Solution { public static void main(String[] args) throws IOException { //Create new instance of SearchFileVisitor(). SearchFileVisitor searchFileVisitor = new SearchFileVisitor(); //Setting search parameters here... amigo, programmer, fileSize, etc. searchFileVisitor.setPartOfName("amigo"); searchFileVisitor.setPartOfContent("programmer"); //searchFileVisitor.setMinSize(500); searchFileVisitor.setMaxSize(10000); //This initiates something relative to the visitFile() in SearchFileVisitor class. //It seems like Paths.get() simply returns a directory from a String. Similar to File. //walkFileTree through this folder, using the parameters of searchFileVisitor. It needs to add those files //that match those results to its foundFiles field. Files.walkFileTree(Paths.get("C:/Users/Mike/Desktop/stuff"), searchFileVisitor); List<Path> foundFiles = searchFileVisitor.getFoundFiles(); for (Path file : foundFiles) { System.out.println(file); } } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

5 April 2023, 20:35

Some thoughts in the visitFile() method: - Line 30 reads all the bytes in the file. Line 34 creates a BufferedReader object to read the file again. You should be able to get rid of that and just convert the bytes to a String:

byte[] content = Files.readAllBytes(file);
String strContents = new String(content);

and then use the contains() method on that String. - Part of name should be found in the file name and not in the file's contents Tip: You don't need to check every single condition when, for example, one of the conditions fails. In this case the file should only be added if ALL conditions are true. It is better to check if a condition passes and if not then end the method at that point: example:

if(!fileName.contains(partOfName)) return FileVisitResult.CONTINUE;

if(!content.contains(partOfContent)) return FileVisitResult.CONTINUE;

if(size > maxSize || size < minSize) return FileVisitResult.CONTINUE;

addToFound(file);
return FileVisitResult.CONTINUE;

If any of those if statements are true (meaning a condition to add doesn't exist) then it just ends there and continues. You could put those in any order. Just remember that the fields will have their default value (null for objects, 0 for primitives) if it is not changed. In that case you can just assume a default value is an automatic pass.

Mike S

Level 28 , Saint Louis, United States

5 April 2023, 22:15

Thank you, Guadalupe. I just tried your recommendations along with a half dozen other variations of it and it still won't pass although it did accept the last condition. Great test of patience for holy week

Thomas

Level 41 , Bayreuth, Germany

6 April 2023, 08:00

maxSize check is buggy. Fixing that probably will help a lot. And I won't start with reading the file content when it is not absolutely necessary. And it is only necessary when minSize, maxSize and parOfName checks succeed. The file size you can get from the BasicFileAttributes object (parameter of the visitFile() method)