Infinite loop !

Question about the task

Resolved

Hello everyone, Please, can someone tell me why the validator keeps telling me that I have an infinite loop (in LoginCommand implementation)? Thanks.

Congratulations! You implemented WithdrawCommand! The main functionality is finished. Next you can do some polishing and make things pretty.
Let's implement one sweet feature. We can get by without it, but it will make things more beautiful.
I'm talking about verification of the user's credit card. No, there won't be any third-party API. Just processing of data from the console.

Let's call this the LOGIN operation and make a corresponding command.
1. Add the LOGIN operation with ordinal 0
2. Prevent the user from selecting this operation from the list.
In the only method for selecting operations, use the operation's ordinal to deny access — throw an IllegalArgumentException.
3. Create LoginCommand by analogy with the other commands. In this command, hardcode card number and PIN code 123456789012 and 1234, respectively.
4. Implement the following logic for LoginCommand:
4.1. Until the user enters a valid card number and PIN code, perform the following actions:
4.2. Request 2 numbers from the user: a 12-digit credit card number and a 4-digit PIN code.
4.3. Display a message if the user enters invalid data.
4.4. If the data is valid, then compare them with the hardcoded values (123456789012 and 1234).
4.5. If the user enters the data specified in item 4.4, then report that the verification was successful.
4.6. If the user does NOT enter the data specified in item 4.4, then return to item 4.1.
5. Fix CommandExecutor. Add the new operation to allKnownCommandsMap.
6. Fix the main method.
The LOGIN operation must be run once before any other operations are performed.
Don't forget about InterruptedOperationExceptions anywhere the user can stop working with the ATM. So, call the operation inside a try-catch block.

Requirements:

The Operation enum must have a LOGIN operation with ordinal 0.
In the getAllowableOperationByOrdinal(Integer i) method, prevent the user from selecting the LOGIN operation.
The LoginCommand class's execute method must implement an algorithm for the LOGIN command according to the task conditions.
The CommandExecutor class's allKnownCommandsMap field must contain the new operation.
The main method should call the LOGIN operation.

package com.codegym.task.task26.task2613; import com.codegym.task.task26.task2613.command.CommandExecutor; import com.codegym.task.task26.task2613.exception.InterruptedOperationException; import java.util.Locale; public class CashMachine { public static void main(String[] args) { Locale.setDefault(Locale.ENGLISH); try { Operation operation = Operation.LOGIN; CommandExecutor.execute(operation); do { operation = ConsoleHelper.requestOperation(); CommandExecutor.execute(operation); } while (operation != Operation.EXIT); } catch (InterruptedOperationException ignored) { ConsoleHelper.writeMessage("Session terminated. Thank you for using the CodeGym ATM. Good luck."); } } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Coboliste

Level 46 , Casablanca, Morocco

16 April 2023, 21:41

public void execute() throws InterruptedOperationException {
        writeMessage("Logging in...");

        while (true) {
            writeMessage("Please enter your credit card number and PIN code, or type 'EXIT' to exit.");
            String creditCardNumber = readString();
            String pinStr = readString();
            if (creditCardNumber.trim().length() != 12 || pinStr.trim().length() != 4) {
                writeMessage("Please enter a valid credit card number (12 digits) or PIN code (4 digits).");
            } else {
                    if (creditCardNumber.equals(PAN) && pinStr.equals(PIN)) {
                        writeMessage(String.format("Credit card [%s] is verified successfully!", creditCardNumber));
                        break;
                    } else {
                        writeMessage(String.format("Credit card [%s] has not been verified.", creditCardNumber));
                        writeMessage("Please try again or type 'EXIT' to exit immediately.");
                    }
            }
        }
    }

Coboliste

Level 46 , Casablanca, Morocco

16 April 2023, 21:41

Hi Thomas, No it was not asked in the requirements, I just used it because I was already created it before in the Manipulator class, Now that I changed my code (see next comment), it was validated, thanks.

Thomas

Level 41 , Bayreuth, Germany

16 April 2023, 21:32

Is that isNumeric method asked by the task conditions? It seems not really useful to me. Eg. it allows numbers like: 1.0E-9 and that's clearly not what you want. The else message tells you what you need to test for: a length of 12 and 4 This may or not may not be the reason why validation hangs. But probably it's worth a try?