The program ran too long and was closed!

Question about the task

Under discussion

I have question. Is there something wrong in this code or are my general assumptions correct? Program print good result and finished with exit code 0. EDIT: I added "mail.notifyAll();" in last line in run method in MailServer but still "Too long" info.

package com.codegym.task.task27.task2710; public class Mail { private String text; protected volatile boolean isMailSend = false; public String getText() { return text; } public void setText(String text) { this.text = text; } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

matemate123

Level 50 , Kraków, Poland

2 June 2023, 05:25

OK this is the answer and my accepted solution but maybe someone could explain me the difference? I liked more my first try with using variable isMailSend. I suppose performance was poorer with two wait() and two notifyAll() calls.

// MailServer.java
 @Override
    public void run() {
        long startTime = System.currentTimeMillis();
        String name = Thread.currentThread().getName();
        synchronized (mail) {
            while (mail.getText() == null) {
                try {
                    mail.wait();
                } catch (InterruptedException e) {
                    throw new RuntimeException(e);
                }
            }
            long endTime = System.currentTimeMillis();
            System.out.format("%s MailServer received: [%s] in %d ms after start", name, mail.getText(), (endTime - startTime));
        }
    }

// Person.java
@Override
    public void run() {
        String name = Thread.currentThread().getName();
        try {
            Thread.sleep(1000);
            synchronized (mail) {
                mail.setText("Person [" + name + "] wrote an email 'AAA'");
                mail.notifyAll();
            }
        } catch (InterruptedException e) {
            e.printStackTrace();
        }
    }

Guadalupe Gagnon

Level 37 , Tampa, United States

3 June 2023, 03:12

useful

The validator will take your code and try it, piece by piece, with their code to ensure that your code is doing what is specified by the instructions. In this task the requirements, and notes in the starting code, specify that only the Person class and Mailserver class are to be modified. This tells me that the Solution class and the Mail class are not tested. When this is the case codegym will actually replace those classes with their own class to ensure your code works as specified. So, in your first code that was not completing the Mail class has an added field that is used in the Person and MailServer class. Because that field most likely doesn't exist in the test code, the validator is just going to error out and fail., and do so with hardly any explanation as to why. Just remember that most (but not all) of the time the validator will take the section of code you wrote and test that it works as intended with their own classes, so making modifications to other classes can have some very bizarre effects on the validator when otherwise it seems like what you coded works as intendid.

matemate123

Level 50 , Kraków, Poland

3 June 2023, 06:21

Ok it make sense, I must take this into consideration in the future. Thank you!