Every time i try verifying my solution i get this: The program ran too long and was closed!

Question about the task

Under discussion

My validation won't just go through . It works for all the other challenges, but for this particular one it doesn't. In the meantime somebody please tell me if this code will get verified if the system works again.

Use the keyboard to enter numbers.
If the user enters -1, display the sum of all entered numbers and end the program.
-1 should be included in the sum.

Hint: one of the solutions to this problem uses the following construct:

while (true) {
    int number = read the number;
    if (check whether the number is -1)
        break;
}

Requirements:

The program should read the numbers from the keyboard.
If the user enters -1, the program should display the sum of all entered numbers and then end.
The program must calculate and display the sum of the entered numbers.
The program must use a for loop or a while loop.

package com.codegym.task.task04.task0442; /* Adding */ import java.io.*; public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String num1 = reader.readLine(); String num2 = reader.readLine(); int a = Integer.parseInt(num1); int sum = 0; while (a!= -1) { int b = Integer.parseInt(num2); if (b == -1) { sum = a + b; System.out.println(sum); break; } } } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Love Patel

Level 5 , San Leandro, United States

28 February 2019, 03:22

here is an optimal solution:

BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
        int number = 0;
        int total = 0;
        while(number != -1){
            number = Integer.parseInt(reader.readLine());
            total += number;
        }
        System.out.print(total);

hidden #10424566

Level 7

10 February 2019, 02:03

Thank you guys, it worked!

Guadalupe Gagnon

Level 37 , Tampa, United States

8 February 2019, 16:27

Sarukei pointed out what is wrong with your code. To pass this task your code needs to accept user inputs until the number -1 is entered. This means it can accept any amount of inputs from 1 to infinity (well more technically until memory runs out). As of now your code only accepts 2 inputs, and unless one of them is -1, it runs in an infinite loop. I'll give you just a little help, then leave you to figure out the rest: Get rid of lines 14 through 16, then change line 21 to:

int b = Integer.parseInt(reader.readline());

Good luck with solving this task!

OnigiriByte

Level 16

8 February 2019, 16:02

When that happens it's most likely that it got stuck in an infinite loop, and that's what seems to be the case here. Your while loop will loop until variable a is equal to -1. According to your code it, variable a will only equal -1 if the user enters it the first time. Also, in your code variable a is only ever changed outside the loop, inside the while loop it never updates variable a.