i dont know why im getting exceptions after handling it

Question about the task

Different methods for different types

Java Core, Level 5, Lesson 12

Under discussion

any one can explain please

1. Read data from the console until the word "exit" is entered.
2. For each value (except "exit"), call the print method. If the value:
2.1. contains a period ("."), then call the print method for Double;
2.2. is greater than zero, but less than 128, then call the print method for short;
2.3. less than or equal to zero or greater than or equal to 128, then call the print method for Integer;
2.4. otherwise, call the print method for String.

Requirements:

The program must read data from the keyboard.
The program should stop reading data from the keyboard after "exit" is entered.
If the entered string contains a period (".") and can be correctly converted to a Double, the print(Double value) method should be called.
If the entered string can be correctly converted to a short and the resulting number is greater than 0, but less than 128, the print(short value) method should be called.
If the entered string can be correctly converted to an Integer and the resulting number is less than or equal to 0 or greater than or equal to 128, the print(Integer value) method should be called.
In all other cases, the print(String value) method should be called.

package com.codegym.task.task15.task1519; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; /* Different methods for different types */ public class Solution { public static void main(String[] args) throws IOException { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); String s = reader.readLine(); int i = Integer.parseInt(s); while (!(s.equals("exit"))){ try { if (s.contains(".")) { print(Double.parseDouble(s)); } else if (i > 0 && i < 128) { print((short) i); } else { print(i); } } catch (Exception e) { print((String) s); } } reader.close(); } public static void print(Double value) { System.out.println("This is a Double. Value: " + value); } public static void print(String value) { System.out.println("This is a String. Value: " + value); } public static void print(short value) { System.out.println("This is a short. Value: " + value); } public static void print(Integer value) { System.out.println("This is an Integer. Value: " + value); } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

matemate123

Level 43 , Kraków, Poland

6 September, 10:51

useful

For start you must add another place to user input to prevent endless loop. Because now if you type for example "10" you are endless loop printing "This is a short. Value: " + value Add: s = reader.readLine(); on the end while loop to read another input and then if you write "exit" loop ends. Second mistake is parse int at the begining after read String. // line 18 If user input is String you have error at this point. I see what you tried. It's good idea from try catch block. Try a little rearrranged it. In first try block you can try:

int i = Integer.parseInt(s);

if success you check if i is Short or not and print. If not success catch and try double parse:

double d = Double.parseDouble(s);

if success ten print(d) if not do another inner catch and then print(s); <-- it's mean it must be string

jamuna

Level 18 , tirunelveli, India

7 September, 16:45

Thankyou

Thomas

Level 41 , Bayreuth, Germany

6 September, 10:19

useful

line 18... that possible NumberFormatException you do not handle. If you type enter anything different than a string that can be parsed to an int the NumberFormatException got thrown.

jamuna

Level 18 , tirunelveli, India

7 September, 16:44

Thankyou