Code fails testing despite achieving expected output.

Question about the task

Under discussion

I have tried the toString() return statement with and without the additional quotes. The program accurately displays 15 statements on the console, sequentially as well, due to the usage of join(). Yet, the code tester says that the program displays too much on the console. Could anyone tell as to why the code fails to clear testing in this implementation?

1. Change the GenerateThread class to make it a thread.
2. Create a GenerateThread constructor, which must:
2.1. Call the superclass's constructor, passing the created thread's number as a String. Use createdThreadCount.
2.2. Start the current thread.
2.3. The thread numbers must start with 1.
3. Override the toString method: inside GenerateThread, use Alt+Insert -> Override Methods. Start typing "toString".
3.1. The toString method must return the current thread number and the word "created". Use getName().

Example:
8 created

4. If the number of created threads is less than Solution.count, the run method must:
4.1. Create a new GenerateThread.
4.2. Display the thread created in Item 4.1.
5. In the end, 15 lines should be output to the console.

Requirements:

The GenerateThread class should inherit the Thread class.
The GenerateThread class must have a public no-argument constructor.
The GenerateThread class constructor should increment createdThreadCount and pass it as a string to the superclass constructor.
The GenerateThread class constructor must start the thread.
The GenerateThread class's toString method must return the thread name and the word " created". Example: "8 created".
If the number of created threads is less than Solution.count, the run method must create a new GenerateThread.
If the number of created threads is less than Solution.count, the run method must display the created thread.
The program's output must match the task conditions and indicate that all 15 threads have been created.

package com.codegym.task.task16.task1623; /* Creating threads recursively */ public class Solution { static int count = 15; static volatile int countCreatedThreads; public static void main(String[] args) { new GenerateThread(); } public static class GenerateThread extends Thread { public GenerateThread() { super(Integer.toString(++countCreatedThreads)); start(); } @Override public String toString() { return "\"" + Thread.currentThread().getName() + " created" + "\""; } @Override public void run() { while (countCreatedThreads < count) { Thread th = new GenerateThread(); System.out.println(th); try { th.join(); } catch (InterruptedException e) { } } if (countCreatedThreads == count) { Thread th = new GenerateThread(); System.out.println(th); } } } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Pavlo Plynko Java Developer at CodeGym

7 September 2018, 07:17

toString() should return properly string even from another thread:

public static void main(String[] args) {
    System.out.println("-----------" + new GenerateThread());
}

Expected out:

-----------1 created
...

Roman

Level 41

29 August 2018, 10:46

Do not use while loop in the run method.