Am I really not getting the right password?

Question about the task

Under discussion

I thought I'd kind of ensured the generated password contained all the types of data (numerals, lowercase letters and uppercase ones). However, the validator disagrees with that, even though the code produces the output that seems to comply with the requirements... What am I missing?

Implement the getPassword() method, which must return a ByteArrayOutputStream with the bytes comprising the password.
Password requirements:
1) 8 characters.
2) Only numbers and uppercase and lowercase Latin letters.
3) At least one numeral, one lowercase letter, and one uppercase letter.
All generated passwords must be unique.

Example of a valid password:
wMh7smNu

Requirements:

The Solution class must have a getPassword() method that returns a ByteArrayOutputStream with the generated password.
The password must be 8 characters long.
The password must have at least one numeral.
The password must have at least one lowercase Latin letter.
The password must have at least one uppercase Latin letter.
The password must not have characters other than numerals and uppercase and lowercase Latin letters.
Generated passwords must be unique.

package com.codegym.task.task32.task3204; import java.io.ByteArrayInputStream; import java.io.ByteArrayOutputStream; import java.io.IOException; import java.util.Random; /* Password generator */ public class Solution { public static void main(String[] args) throws IOException { ByteArrayOutputStream password = getPassword(); System.out.println(password.toString()); } public static ByteArrayOutputStream getPassword() throws IOException { StringBuilder sb = new StringBuilder(); int counter = 0; boolean numeralAdded = false; boolean lowCaseAdded = false; boolean upperCaseAdded = false; boolean noneAdded = !numeralAdded && !lowCaseAdded && !upperCaseAdded; boolean allAdded = numeralAdded && lowCaseAdded && upperCaseAdded; Random random = new Random(); while (counter != 8) { if (noneAdded || allAdded) { // if the sb is empty or all types are present, // we safely choose a random type of data to be added int type = 1 + (int) (Math.random() * 3); if (type == 1) { char randomLowCase = (char) (random.nextInt(26) + 'a'); sb.append(randomLowCase); lowCaseAdded = true; counter++; } else if (type == 2) { int randomNumeral = 1 + random.nextInt(4); sb.append(randomNumeral); numeralAdded = true; counter++; } else if (type == 3) { char randomUpperCase = (char) (random.nextInt(26) + 'A'); sb.append(randomUpperCase); upperCaseAdded = true; counter++; } } else if (!numeralAdded) { int randomNumeral = 1 + random.nextInt(4); sb.append(randomNumeral); numeralAdded = true; counter++; } else if (!lowCaseAdded) { char randomLowCase = (char) (random.nextInt(26) + 'a'); sb.append(randomLowCase); lowCaseAdded = true; counter++; } else if (!upperCaseAdded) { char randomUpperCase = (char) (random.nextInt(26) + 'A'); sb.append(randomUpperCase); upperCaseAdded = true; counter++; } } String password = sb.toString(); ByteArrayInputStream bais = new ByteArrayInputStream(password.getBytes()); ByteArrayOutputStream baos = new ByteArrayOutputStream(); while (bais.available() > 0) { int data = bais.read(); baos.write(data); } bais.close(); return baos; } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

5 June, 13:53

The very first time I ran your code I received this password: P23PVJ3O The problem is that line 29 will always be true because noneAdded and allAdded never change after they are initiated on lines 25 and 26. This results in lines 49-64 being unreachable. You can see this by adding a sys.out.prln() inside the first if block like this:

if (noneAdded || allAdded) {
    System.out.println("\tint first block");
    //if the sb is empty or all types are present,
    // etc....

It outputs that line 8 times each time the method is called before a result is returned.

Evgeniia Shabaeva

Level 41 , Budapest, Hungary

6 June, 08:32

I see. Haven't thought about it, thank you.

Evgeniia Shabaeva

Level 41 , Budapest, Hungary

6 June, 08:53

Thank you once again for the point made; I moved lines 25 & 26 to the beginning of the while-loop, and it worked.