what is the trick here ? can someone tell me please? the code works fine on notepad

Question about the task

Under discussion

public class Solution { //main method public static void main(String[] args) throws Exception { //declare local variables int n1=0; int nNeg=0; int nPos=0; int i=0; //prepare keyboard to input BufferedReader br = new BufferedReader(new InputStreamReader(System.in)); while (i<=2){ n1 = Integer.parseInt(br.readLine()); if (n1==0){ break; } else if (n1>0){ nPos++; i++; } else { nNeg++; i++; } } System.out.println("Number of negative numbers: " + nNeg); System.out.println("Number of positive numbers: " + nPos); } }

Use the keyboard to enter three integers. Display the number of positive numbers and the number of negative numbers in the original set, in the following form:
"Number of negative numbers: a" and "Number of positive numbers: b", where a and b are the unknowns.

Here are some examples:
a) if you enter the numbers
2
5
6
then we display
Number of negative numbers: 0 Number of positive numbers: 3

b) if you enter the numbers
-2
-5
6
then we display
Number of negative numbers: 2 Number of positive numbers: 1

Requirements:

The program should read the numbers from the keyboard.
The program should display text on the screen.
The program should display the number negative numbers in the original set.
The program should display the number of positive numbers in the original set.
If there are no negative numbers, the program should display "Number of negative numbers: 0".
If there are no positive numbers, the program should display "Number of positive numbers: 0".
Note that 0 is not a positive or negative number.

package com.codegym.task.task04.task0429; /* Positive and negative numbers */ import java.io.*; public class Solution { //main method public static void main(String[] args) throws Exception { //declare local variables int n1=0; int nNeg=0; int nPos=0; int i=0; //prepare keyboard to input BufferedReader br = new BufferedReader(new InputStreamReader(System.in)); while (i<=2){ n1 = Integer.parseInt(br.readLine()); if (n1==0){ break; } else if (n1>0){ nPos++; i++; } else { nNeg++; i++; } } System.out.println("Number of negative numbers: " + nNeg); System.out.println("Number of positive numbers: " + nPos); } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Qadir Khan

Level 9 , Germany

20 November 2019, 00:13

why you make it soo complicated , no need to use the for loop int a = Integer.parseInt(reader.readLine()); int b = Integer.parseInt(reader.readLine()); int c = Integer.parseInt(reader.readLine()); int count=0; int c2 = 0; if (a != 0 ) if( a > 0 ) count++; else c2++; if(b != 0) if( b > 0 ) count++; else c2++; if(c != 0) if( c > 0 ) count++; else c2++; System.out.println("Number of negative numbers: "+ c2); System.out.println("Number of positive numbers: " + count);

Вячеслав Холод

Level 8 , Murmansk, Russian Federation

13 June 2020, 04:50

You don't need so many variables. Scanner can = new Scanner(System.in); int countN = 0; int countP = 0; int a; for (int x = 0; x < 3; x++){ a = can.nextInt(); if (a > 0) countP++; else if (a < 0) countN++; } can.close(); System.out.println("Number of positive numbers: " + countP); System.out.println("Number of negative numbers: " + countN);

Talha

Level 5 , Lahore, Pakistan

24 August 2019, 21:13

0 is counted but nothing should be incremented for it. So,Dont break the loop for n1==0 and convert "else" to "else if" and give it the condition (n1<0)

Anonymous #10428383

Level 12 , Seattle, United States

25 March 2019, 19:44

thanks for let me know that input "zero" must to be counted. i was just thinking about the requirement says to enter "three" integers, but i had forgot that "zero" is integer too. well, that looks an very easy task, after the information that input "zero" must to be counted and "zero" is a integer. Please, give us that "hints" whenever is possible :) , because it is hard to guess what the requirements really means sometimes, when you don't have a chance to ask, and i think this situation "do not really add any knowledge on the mastering of the language syntax " since it's just a simple forward three times inputs for the keyboard counting and displaying staff. please again, don't take this comments as a bad, i just thinking if i would teach someone a thing i should give him the best clues about that thing for his fast mastering about it. so i would try to avoid possibles misinterpretations, since you never know what type requirements or logic your code will needs to be improved or not , and so on.. i think in any process learning system the questioning is crucial but the doubt question/requirement teaching is not necessary, is an waste of time. thanks for read. have a great day :)

Guadalupe Gagnon

Level 37 , Tampa, United States

25 March 2019, 13:16

Line 23 breaks the entire loop if 0 is entered, even if it is the first number entered. You probably want to use 'continue' instead. Also you need to make sure that you increment i by 1 even when 0 is entered. It would make more sense to get rid of lines 22-24, 27, and 31; then add 'i++;' before the end of the loop, between lined 32 and 33.