Correct output but it doesn't pass verification

Question about the task

Resolved

I've tested my getDialString method for the phone numbers from examples and it shows correct output, but it doesn't pass the verification. The recommendation from mentor is: " The getDialString() method should return a String containing "callto://+" and a phone number with all characters removed except digits (see the examples). The phone number must be retrieved using the contact field's getPhoneNumber() method. ". Is there something wrong in my code?

Adapt Customer and Contact to RowItem.
The adapter class is DataAdapter.

Initialize countries before running the program. Mapping between country codes and country names:
UA Ukraine
US United States
FR France

Requirements:

The Solution class must have a public static Map<String, String> field called countries.
Initialize the countries field in a static block in the Solution class using the test data provided in the task.
The Solution class must have a RowItem interface.
The Solution class must have a Contact interface.
The Solution class must have a Customer interface.
The DataAdapter class must implement the RowItem interface.
The DataAdapter class must contain two private fields: Customer customer and Contact contact.
The DataAdapter class must have a constructor with (Customer customer, Contact contact) parameters. It must initialize the contact and customer fields.
Implement the RowItem interface methods in the DataAdapter class using the hints in the comments in the interfaces.

package com.codegym.task.task19.task1905; import java.util.HashMap; import java.util.Map; /* Reinforce the adapter */ public class Solution { public static Map<String,String> countries = new HashMap<>(); static{ countries.put("UA", "Ukraine"); countries.put("US", "United States"); countries.put("FR", "France"); } public static void main(String[] args) { } public static class DataAdapter implements RowItem{ private Customer customer; private Contact contact; public DataAdapter(Customer customer, Contact contact) { this.customer = customer; this.contact = contact; } public String getCountryCode() { String countryCode = ""; for (Map.Entry<String, String> pair : countries.entrySet()) { if (pair.getValue().equals(customer.getCountryName())) { countryCode = pair.getKey(); } } return countryCode; } public String getCompany() { return customer.getCompanyName(); } public String getContactFirstName() { String firstName = contact.getName(); return firstName.substring(firstName.lastIndexOf(" ")+ 1); } public String getContactLastName() { String lastName = contact.getName(); return lastName.substring(0, lastName.indexOf(",")); } public String getDialString() { StringBuilder sb = new StringBuilder(contact.getPhoneNumber()); sb.deleteCharAt(sb.indexOf("+")); sb.deleteCharAt(sb.indexOf("(")); sb.deleteCharAt(sb.indexOf(")")); sb.deleteCharAt(sb.indexOf("-")); return "callto://+" + sb.toString(); } } public static interface RowItem { String getCountryCode(); // For example: US String getCompany(); // For example: CodeGym Ltd. String getContactFirstName(); // For example: John String getContactLastName(); // For example: Peterson String getDialString(); // For example: callto://+11112223333 } public static interface Customer { String getCompanyName(); // For example: CodeGym Ltd. String getCountryName(); // For example: United States } public static interface Contact { String getName(); // For example: Peterson, John String getPhoneNumber(); // For example: +1(111)222-3333, +3(805)0123-4567, +380(50)123-4567, etc. } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

27 March 2019, 13:40

useful

I am thinking that most likely it is the getContactFirstName method. Some first names have more than one word, like 'Joy Ann'. In this case the above code would only return 'Ann' instead of the full first name. Try making changes to account for this and see if that works.

Zbigniew

Level 23 , Dabrowa Tarnowska, Poland

28 March 2019, 07:59

I've changed the getContactFirstName method to the following:

public String getContactFirstName() {
            String firstName = contact.getName();
            return firstName.substring(firstName.indexOf(" ")+ 1);
        }

It shows correct output for two- part first names, but it didn't change the validation result.

Guadalupe Gagnon

Level 37 , Tampa, United States

28 March 2019, 13:28

solution

try this for the getDialString method:

public String getDialString() {
   return "callto://+" + contact.getPhoneNumber.replaceAll("[^0-9]", "");
}

+13

Zbigniew

Level 23 , Dabrowa Tarnowska, Poland

30 March 2019, 11:07

It worked, thank you, you're the best. But how should i understand the arguments in replaceAll method? Do I understand correctly that it means: replace all characters which are not digits with empty string? (""). Besides, i have seen such things like : [^0-9] or [a-z, A-Z] lately, but i don't know how they are called, thus i can't find any information about their usage. Can you help me with that? [EDIT] Those things are called regular expressions, in case if someone wondered. You can read about them here: https://www.vogella.com/tutorials/JavaRegularExpressions/article.html

Guadalupe Gagnon

Level 37 , Tampa, United States

30 March 2019, 21:14

You can Google a guide to help with that. In the above method it is saying to replace everything that is not the numbers 0 through 9. If you wanted to replace numbers 0-9 you can remove the "^". Check out a guide and practice with it, it is a very useful method.