What's wrong in this code. Help needed.

Question about the task

Under discussion

Somebody help me with this. It's not accepting the code. What's wrong with this. I cannot find (It's showing "If cat1 beats cat2, then cat2 must lose to cat1.").

Implement the boolean fight(Cat anotherCat) method:
implement a mechanism for cats to fight based on their weight, age and strength.
You can decide for yourself how a cat's characteristics factor into combat.
The method should determine whether we (this) won the fight, i.e. return true if we won and false if not.

The following condition must be met:
if cat1.fight(cat2) returns true,
then cat2.fight(cat1) must return false

Requirements:

The Cat class must have a constructor with no parameters.
The Cat class must contain public fields age, weight, and strength.
The Cat class must have a fight method.
In the fight method, implement a mechanism for cats to fight based on their weight, age and strength.
The method should return the same value every time we fight the same cat.
If cat1 beats cat2, then cat2 must lose to cat1.

package com.codegym.task.task05.task0502; /* Implement the fight method */ public class Cat { public int age; public int weight; public int strength; public Cat() { } public boolean fight(Cat anotherCat) { //write your code here if(this.age>=anotherCat.age && this.weight<=anotherCat.weight && this.strength>anotherCat.strength) { return true; } else { return false; } } public static void main(String[] args) { Cat cat1 = new Cat(); Cat cat2 = new Cat(); cat1.age = 4; cat1.weight = 24; cat1.strength = 99; cat2.age = 3; cat2.weight = 25; cat2.strength = 98; } }

Comments (13)

Popular
New
Old

You must be signed in to leave a comment

DavidJugaad

Level 10

26 July 2021, 19:33

You don´t need to implement main method. The requirements are strictly implement the fight method, to pass the test. YAGNI...

Ahu

Level 5 , Slough, United Kingdom

13 May 2021, 22:45

The solution is this: public boolean fight(Cat anotherCat) { int agePlus = this.age > anotherCat.age ? 1 : 0; int weightPlus = this.weight > anotherCat.weight ? 1 : 0; int strengthPlus = this.strength > anotherCat.strength ? 1 : 0; int score = agePlus + weightPlus + strengthPlus; return score > 2; }

Ravi Kumar

Level 5 , Jaipur, India

25 October 2019, 15:58

Try this approach, it worked for me though. If you have any doubts then feel free to ask me.

public class Cat {
    public int age;
    public int weight;
    public int strength;

    public Cat() {
    }

    public boolean fight(Cat anotherCat) {
        //write your code here
        if((this.strength>anotherCat.strength)&&(this.weight>anotherCat.weight)&&(this.age>anotherCat.age)){
            return true;
        }
        else
            return false;

    }

    public static void main(String[] args) {
        Cat cat1 = new Cat();
        Cat cat2 = new Cat();
        cat1.strength=20;
        cat1.age=5;
        cat1.weight=20;
        cat2.age=10;
        cat2.weight=15;
        cat2.strength=13;
        System.out.println(cat1.fight(cat2));
        System.out.println(cat2.fight(cat1));
    }
}

yehuda b

Level 23 , Beersheba, Israel

3 December 2019, 16:51

Why wouldn't both return false?? (all 3 variables in your fight method have to be more than the other object's variables)

hidden #10517108

Level 14

23 September 2019, 04:09

this.weight <= anotherCat.weight should be a >= and it didn't need anything in the main method from me

Antonia

Level 10 , Greece

12 July 2019, 09:31

check "if" something is wrong

Abhishek Rangari

Level 22 , Nagpur, India

26 October 2018, 18:19

if( (this.age>=anotherCat.age) && (this.weight<=anotherCat.weight) && (this.strength>anotherCat.strength)) { return true; } else { return false; } public static void main(String[] args) { Cat cat1 = new Cat(); cat1.age = 12; cat1.weight = 23; cat1.strength = 40; Cat cat2 = new Cat(); cat2.age = 22; cat2.weight = 24; cat2.strength = 50; System.out.println(cat1.fight(cat2)); System.out.println(cat2.fight(cat1)); }

WatWat

Level 9 , Vancouver, Canada

9 October 2018, 06:13

Take all that code out of the main method and try and think of another way to calculate the stats to determine the winner of a fight. Like adding up all of this cats stats in one variable and anotherCat stats in another and return the comparison of those 2 variables

Roman

Level 41

28 August 2018, 12:42

Try to test with this main method:

public static void main(String[] args) {
        Cat cat1 = new Cat();
        Cat cat2 = new Cat();
        cat1.age = 4;
        cat1.weight = 24;
        cat1.strength = 99;
        cat2.age = 3;
        cat2.weight = 23;
        cat2.strength = 98;
        System.out.println(cat1.fight(cat2));
        System.out.println(cat2.fight(cat1));
    }

results must be different.