CodeGym/Help with Java Tasks/HELP MEEE

Level 6

Delhi

12.04.2019
2112views
12comments

HELP MEEE

Question about the task

Adding

Java Syntax, Level 4, Lesson 16

Resolved

What is wrong with my code? :'(

Use the keyboard to enter numbers.
If the user enters -1, display the sum of all entered numbers and end the program.
-1 should be included in the sum.

Hint: one of the solutions to this problem uses the following construct:

while (true) {
    int number = read the number;
    if (check whether the number is -1)
        break;
}

Requirements:

The program should read the numbers from the keyboard.
If the user enters -1, the program should display the sum of all entered numbers and then end.
The program must calculate and display the sum of the entered numbers.
The program must use a for loop or a while loop.

package com.codegym.task.task04.task0442; import java.io.*; public class Solution { public static int calcEntry = 0; public static void main(String[] args) throws Exception { //write your code here BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); // Store the all entry number while(true) { int entryNumber = Integer.parseInt(reader.readLine()); if( calcEntry == -1 ) calcEntry += entryNumber; System.out.println(calcEntry); break; } } }

Comments (12)

Popular
New
Old

You must be signed in to leave a comment

past cham

Level 6 , Delhi, India

16 May 2019, 13:27

import java.io.*; public class Solution { public static void main(String[] args) throws Exception { //write your code here int c = 0; BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); while(true) { int entryNumber = Integer.parseInt(reader.readLine()); c += entryNumber; if (entryNumber == -1) break; hhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhhh

Guadalupe Gagnon

Level 37 , Tampa, United States

12 April 2019, 17:22

You need to rethink the logic of your while loop. It will output 0 no matter what you enter. I have included a step-by-step of what is happening if you enter the number 5

while(true) {
   int entryNumber = Integer.parseInt(reader.readLine()); // enter 5

   //↓ this should be checking entryNumber not calcEntry, also moved to last step in while loop
   if( calcEntry == -1 ) // checks calcEntry if value is equal to -1 (false)
      calcEntry += entryNumber; // never reached

   //↓ this should be after the while loop concludes
   System.out.println(calcEntry); // outputs calcEntry - 0

   break; // breaks loop
   //↑ this should be directly after the 'if' check for -1
}

Abdur Rehman

Level 7 , Faisalabad, Pakistan

12 May 2019, 12:09

on line 2 what do u mean by enter 5 like do i have to do something u r just visualising it

Abdur Rehman

Level 7 , Faisalabad, Pakistan

12 May 2019, 12:12

public class Solution { public static int c = 0; public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); while(true) { int entryNumber = Integer.parseInt(reader.readLine()); if (entryNumber == -1) break; c += entryNumber; System.out.println(c); } } }

Abdur Rehman

Level 7 , Faisalabad, Pakistan

12 May 2019, 12:13

this is my code and its still saying that myprogrsm is not calculating the amount correctly

Guadalupe Gagnon

Level 37 , Tampa, United States

12 May 2019, 15:50

useful

Move the int c into the main method, you dont want to use static variables unless called for. Next the output should only be shown one time, you need to put it on the outside of your while loop.

Abdur Rehman

Level 7 , Faisalabad, Pakistan

13 May 2019, 11:42

public class Solution { public static void main(String[] args) throws Exception { int c = 0; BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); while(true) { int entryNumber = Integer.parseInt(reader.readLine()); if (entryNumber == -1) break; c += entryNumber; } System.out.println(c); } } i actually did what you asked but now its saying that -1 should be in the included sum

Guadalupe Gagnon

Level 37 , Tampa, United States

13 May 2019, 13:23

move the line: 'c+= entrynumber' to before the if statement and below the line that gets user input.

Abdur Rehman

Level 7 , Faisalabad, Pakistan

13 May 2019, 13:27

it worked but i also want to learn the logic behind it can you tell me

Guadalupe Gagnon

Level 37 , Tampa, United States

13 May 2019, 14:58

solution

while(true) {
      // this line gets the user input and converts to a number
      int entryNumber = Integer.parseInt(reader.readLine());
      // this line adds to the value of 'c' the user input
      c += entryNumber;
      // this line checks if the user input is -1 and if it is breaks the loop
      if (entryNumber == -1)
         break;
   }
  // this line outputs 'c' which is the total sum
   System.out.println(c);
}

Abdur Rehman

Level 7 , Faisalabad, Pakistan

13 May 2019, 15:05

thx bro you really know alot

Ivan

Level 22 , Nope, Bulgaria

31 July 2019, 13:17

Where does the -1 come in to play? You get the sum of the numbers entered but the task requires to subtract -1.