Unable to pass Validation.

Question about the task

Under discussion

My testing seems to pass all validation criteria, however validation fails for: - When the program is run with the arguments "-c productName price quantity", a new line with the corresponding product should be added to the end of the file. - The product must have the next id after the maximum id found in the file. - The format of the new product line must precisely match that format specified in the task. - The file streams must be closed. - recommendation from your mentor - The file input stream was not closed. I replaced try with resources solution with explicit close and that did not seem to change anything. Any help/ideas would be greatly appreciated.

CrUD for a table inside a file.
Read a file name for CrUD operations from the console.

The program is started with the following arguments:
-c productName price quantity

Argument values:
where id is 8 characters.
productName is 30 characters.
price is 8 characters.
quantity is 4 characters.
-c adds the product with the specified parameters to the end of the file, and generates an id by incrementing the maximum id found in the file.

The file data is stored in the following order (without separating spaces):
id productName price quantity

Each data field is padded with spaces up to its length.

Before adding a new line, re-write all of its contents to the file.

Example:
19847 Swim trunks, blue 159.00 12 198479 Swim trunks, black with printe173.00 17 19847983Snowboard jacket with reflecti10173.991234

Requirements:

The program should read a file name for CrUD operations from the console.
The Solution class should not use static variables.
When you run the program without arguments, the product list must remain unchanged.
When the program is run with the arguments "-c productName price quantity", a new line with the corresponding product should be added to the end of the file.
The product must have the next id after the maximum id found in the file.
The format of the new product line must precisely match that format specified in the task.
The file streams must be closed.

package com.codegym.task.task18.task1827; /* Prices */ import java.io.*; import java.nio.file.Files; import java.util.ArrayList; import java.util.List; public class Solution { public static void main(String[] args) throws Exception { if (args.length == 0) return; String fileName = ""; try (BufferedReader reader = new BufferedReader(new InputStreamReader(System.in))) { fileName = reader.readLine(); } if ("-c".equalsIgnoreCase(args[0])) { AddItem(fileName, args[1], args[2], args[3]); } } private static void AddItem(String fileName, String productName, String price, String quantity) throws IOException { File f = new File(fileName); if (!f.isFile()) { Files.createFile(f.toPath()); } List<String> lines = new ArrayList<>(); try (BufferedReader reader = new BufferedReader(new FileReader(fileName))) { int maxId = 0; boolean isMoreLines = true; while (isMoreLines) { String inLine = reader.readLine(); if (inLine == null ) { break; } else if ( "".equals(inLine)) { isMoreLines = false; } else { String idString = inLine.substring(0, 8).trim(); int id = Integer.parseInt(idString); if (id > maxId) maxId = id; } lines.add(inLine); } //add the new product maxId++; String id = String.format("%-8s", Integer.toString(maxId)); String line = String.format("%-8s%-30s%-8s%-4s", id,productName, price, quantity); lines.add(line); } try (BufferedWriter writer = new BufferedWriter(new FileWriter(fileName))){ for (String line : lines) { writer.write(line); writer.newLine(); } } // System.out.println(line); } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Azja

Level 32 , Krakow, Poland

26 April 2019, 17:51

I have problem with 4 condition where when program run with "-c" it should re write and add one line. Add one LINE is key word. I had good program but i was adding to file one by one word and it didn't pass validation. To sum up, i think you should build one line where you add necesary spaces. Next re-write file, and add one full line to the end in new line

Guadalupe Gagnon

Level 37 , Tampa, United States

14 April 2019, 22:43

You're probably failing because lines 28-30 are not necessary. If the file does not exist then that means that the program should error out. The task may want you to actually call the close method on the streams instead of using a 'try with resource' structure. I don't know why the last last requirement is failing otherwise. A little pointer: the buffered reader class already has a method to determine if more data can be read in. Get rid of line 35, lines 36-42, and 46. Change the while loop to (reader.ready()).