Phone number - not sure why it isn't working

Question about the task

Under discussion

Would appreciate some help.

Adapt IncomeData to the Customer and Contact interfaces.
The adapter class is IncomeDataAdapter.
Initialize countries before running the program. Mapping between country codes and country names:
UA Ukraine
US United States
FR France
If necessary, pad phone numbers with zeros to get 10 digits long (see the examples).
Pay attention to the format of people's first and last names.

Requirements:

The Solution class must have a public static Map<String, String> field called countries.
Initialize the countries field in a static block in the Solution class using the test data provided in the task.
The IncomeDataAdapter class must implement the Customer and Contact interfaces.
The IncomeDataAdapter class must have a private IncomeData field called data.
The IncomeDataAdapter class must have a constructor with an IncomeData parameter.
Using the hints in the interfaces' comments, implement the methods of the Customer and Contact interfaces in the IncomeDataAdapter class.

package com.codegym.task.task19.task1903; /* Adapting multiple interfaces */ import java.util.HashMap; import java.util.Map; public class Solution { public static Map<String, String> countries = new HashMap<>(); static { countries.put("UA", "Ukraine"); countries.put("US", "United States"); countries.put("FR", "France"); } public static void main(String[] args) { } public static class IncomeDataAdapter implements Customer, Contact { private IncomeData data; public IncomeDataAdapter(IncomeData data) { this.data = data; } public String getCompanyName() { return data.getCompany(); } public String getCountryName() { return countries.get(data.getCountryCode()); } public String getName() { return data.getContactLastName() + ", " + data.getContactFirstName(); } public String getPhoneNumber() { StringBuilder phoneNumber = new StringBuilder(Integer.toString(data.getPhoneNumber())); if (phoneNumber.length() < 10) { for (int i = 0; i < 10 - phoneNumber.length(); i++) { phoneNumber = phoneNumber.insert(0, "0"); } } assert phoneNumber.length() == 10; return "+" + data.getCountryPhoneCode() + "(" + phoneNumber.substring(0, 3) + ")" + phoneNumber.substring(3, 6) + "-" + phoneNumber.substring(6, 8) + "-" + phoneNumber.substring(8, 10); } } public static interface IncomeData { String getCountryCode(); // For example: US String getCompany(); // For example: CodeGym Ltd. String getContactFirstName(); // For example: John String getContactLastName(); // For example: Smith int getCountryPhoneCode(); // For example: 1 int getPhoneNumber(); // For example: 501234567 } public static interface Customer { String getCompanyName(); // For example: CodeGym Ltd. String getCountryName(); // For example: United States } public static interface Contact { String getName(); // For example: Smith, John String getPhoneNumber(); // For example: +38(050)123-45-67 } }

Comments (8)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

15 April 2019, 01:01

Regular expressions are very useful for problems like this. Google them. They are sort of hard to understand at first but start to make sense when you use them more often I specifically googled padding numbers with 0's on the left and formating telephone numbers (both for java). This is what I came up with that can replace your code in the getPhoneNumber method.

String input = String.format("%010d", Integer.parseLong(data.getPhoneNumber());
return "+" + data.getCountryPhoneCode() + input.replaceFirst("(.{3})(.{3})(.{2})(.{2})", "($1)$2-$3-$4");

The first line of this code pads the phone number from data.getPhoneNumber the required amount of 0's. The second line (passed the getCountryCode) splits that string into 4 sub string with the regular expression "(.{3})(.{3})(.{2})(.{2})". This reads: 1. (.{3}) get any character (denoted by the period) 3 times 2. (.{3}) get the next any character 3 times 3. (.{2}) get the next any character 2 times 4. (.{2}) get the next any character 2 times Then puts those 4 in the string "($1)$2-$3-$4", in order from 1-4 at each $. So $1 would be the first sub string, $2 the second and so on.

+16

Azja

Level 32 , Krakow, Poland

28 April 2019, 18:17

Great explanation! Thank you so much for knowledge about regex. It's very useful. I wonder why you used

Integer.parseLong(data.getPhoneNumber()

because first of all, how can we use parseLong with Integer, and second: already returns int.

data.getPhoneNumber()

I just used this that way:

String number = String.format("%010d", data.getPhoneNumber());

Guadalupe Gagnon

Level 37 , Tampa, United States

29 April 2019, 13:26

Because I used code that I found online through google. When I ran it to make sure it ran on this task, it ran successfully. Good catch though! Something like this could mean a whole extra step that is not needed every time this code is run. If this was real 'call center' code, it could be run hundreds to thousands of times (or more) every minute. This could be a bottle neck in the code that slowed it down just enough to be frustrating to the end use.

Johannes

Level 27 , Centurion, Pretoria, South-Africa

16 April 2020, 11:23

Well thanks Guadalupe, this worked for me. I just don't understand why this code from me, did not work. It's more elaborate, yes, but easy to do and understand. So why does it not work ? public String getPhoneNumber() { String phoneNr = String.valueOf(this.data.getPhoneNumber()); String countryCode = String.valueOf(this.data.getCountryPhoneCode()); //pad phone number in front with zeroes until 10 in length while (phoneNr.length() < 10){ phoneNr = "0" + phoneNr; } String fullPhoneNr = "+" + countryCode + "(" + phoneNr.substring(0,3) + ")" + phoneNr.substring(3,6) + "-" + phoneNr.substring(6,8) + "-" + phoneNr.substring(8,9); return fullPhoneNr; }

Guadalupe Gagnon

Level 37 , Tampa, United States

16 April 2020, 15:02

The last part of the line that puts the full number together should be: phoneNr.substring(8,10); instead of : phoneNr.substring(8,9); The output original was cutting off the last digit.

Johannes

Level 27 , Centurion, Pretoria, South-Africa

17 April 2020, 07:03

Thank you, I initially had it as phoneNr.substring(8); only, as it then goes for the full length of rest of the string ? And that also did not work. And I thought making it (8,10) would not work, as the array is zero based, and 10 long ? Anyhow, I moved on, I think it's the validater looking sometimes for specific ways, instead of all possible ways, to solve the problem. Cannot mark your suggestion now, as the task is complete already, thanks for the assistance :)

Guadalupe Gagnon

Level 37 , Tampa, United States

17 April 2020, 13:58

The subtring method, the second argument for the end point, it ends at the index number starting from 0, so an argument of 10 would end at index 9 of the string.

Johannes

Level 27 , Centurion, Pretoria, South-Africa

18 April 2020, 09:48

cool, thanks