Can't seem to find the problem. Is it the logic at fault?

Question about the task

Under discussion

Am not sure what's wrong with my code. This outputs me the correct answer but I still fail to pass testing (as seen in the img below). Not sure if it's the logic flow or the syntax. If anyone can spot the error, do let me know! Much appreciated!

package com.codegym.task.task02.task0216; /* Minimum of three numbers */ public class Solution { public static int min(int a, int b, int c) { int d; if (a >= b) d = b; if (b >= c) d = c; else if (a >= c) d = c; else d = a; return d; } public static void main(String[] args) throws Exception { System.out.println(min(1, 2, 3)); System.out.println(min(-1, -2, -3)); System.out.println(min(3, 5, 3)); System.out.println(min(5, 5, 10)); } }

Comments (5)

Popular
New
Old

You must be signed in to leave a comment

Austin

Level 6 , Lansing, United States

23 April 2019, 12:54

The only reason I can think of as to why you're getting an error on the return portion, is maybe due to formatting. Here's mine for comparison

int m2;
if (a <= b && a < c)
     m2 = a;
else if (b < a && b < c)
     m2 = b;
else
     m2 = c;

return m2; //this returns the result of the work

Kymie

Level 4 , Singapore, Singapore

17 May 2019, 09:03

Got it! This is much clearer, thank you!

Yudhi Pratama

Level 7 , Jakarta, Indonesia

23 April 2019, 11:40

I've tried your code, and the results are correct. Why the verifier won't accept your code, though? Here's mine, might be useful for comparison.

package com.codegym.task.task02.task0216;

/*
Minimum of three numbers

*/
public class Solution {
    public static int min(int a, int b, int c) {
        int cil = 0;
        if ((a <= b) && (a <= c))
            cil = a;
        else if ((b <= a) && (b <= c))
            cil = b;
        else if ((c <= a) && (c <= b))
            cil = c;
        return cil;
        //write your code here
    }

    public static void main(String[] args) throws Exception {
        System.out.println(min(1, 2, 3));
        System.out.println(min(-1, -2, -3));
        System.out.println(min(3, 5, 3));
        System.out.println(min(5, 5, 10));
    }

}

Kymie

Level 4 , Singapore, Singapore

17 May 2019, 09:05

Have tried this already, thank you! I need to write more cleanly

Haridas Lakayil

Level 8 , Hyderabad, India

23 April 2019, 11:34

package com.codegym.task.task02.task0216; /* Minimum of three numbers */ public class Solution { public static void main(String[] args) throws Exception { System.out.println(min(1, 2, 3)); System.out.println(min(-1, -2, -3)); System.out.println(min(3, 5, 3)); System.out.println(min(5, 5, 10)); } public static int min(int a, int b, int c) { int m; if (a < b) m = a; else m = b; if (c < m) m = c; else m = m; return m; } }