what's wrong?

Question about the task

R or L

Java Syntax, Level 7, Lesson 9

Under discussion

what is wrong?2nd and 3rd conditions are not satisifed

1. Create a list of words and populate it yourself.
2. The fix method should:
2.1. remove all words containing the letter "r" from the list
2.2. duplicate all words containing the letter "l".
2.3. if a word contains both "r" and "l", then leave it unchanged.
2.4. don't do anything to other words.

For example:
rose lyre love

Output:
lyre love love

Requirements:

The program must not read data from the keyboard.
The fix method should remove all words containing the letter "r" from the list. There is an exception: words containing both "r" and "l" should be left alone.
The fix method must duplicate words containing the letter "l" (add another instance of this word to the list). There is an exception: words containing both "l" and "r" should not be duplicated.
The fix method should not do anything with words that contain both "l" and "r".
The fix method should not do anything with words that don't contain either "l" or "r".

package com.codegym.task.task07.task0716; import java.util.ArrayList; /* R or L */ public class Solution { public static void main(String[] args) throws Exception { ArrayList<String> list = new ArrayList<String>(); list.add("rose"); // 0 list.add("red"); // 1 list.add("love"); // 2 list = fix(list); for (String s : list) { System.out.println(s); } } public static ArrayList<String> fix(ArrayList<String> list) { int j=0; ArrayList<String> list2 = new ArrayList<String>(); list2.addAll(list); for(int i=0;i<3;i++ ){ if(!(list.get(i).contains("l"))&& (list.get(i).contains("r"))){ list2.remove(list.get(i)); } else if((list2.get(i).contains("l"))&& !(list.get(i).contains("r"))){ list2.add(list.get(i)); } else if((list.get(i).contains("l"))&& (list.get(i).contains("r"))){ continue; } else if(!(list.get(i).contains("l"))&& !(list.get(i).contains("r"))){ continue; } } return list2; } }

Comments (7)

Popular
New
Old

You must be signed in to leave a comment

Deepak Chandra

Level 16 , Visakhapatnam, India

18 May 2019, 06:55

You can try my code buddy you can piont out any extra code that i have used This code worked but it took me 10 attempts to reach this final result so keep trying.

public static ArrayList<String> fix(ArrayList<String> list) {
        for (int i = 0; i < list.size(); i++){
            if ((list.get(i).indexOf("r") != -1 && list.get(i).indexOf("l") == -1)){
                list.remove(i);
                i--;
            }
        }

        for (int i = 0; i < list.size(); i++){
            if (!(list.get(i).contains("r")) && (list.get(i).contains("l"))){
                list.add(list.get(i));
                break;
            }
        }

        for (int i = 0; i < list.size(); i++){
            if ((list.get(i).contains("r")) && (list.get(i).contains("l"))){
                break;
            }
        }
        return list;
    }

Molchyn

Level 25 , Yahil'nytsya, Ukraine

5 May 2019, 14:41

int j = 0 is not used in us, I forgot to comment

Molchyn

Level 25 , Yahil'nytsya, Ukraine

5 May 2019, 14:38

In line 27, we do not need to copy the array into an array. And a sequence of conditional statements like this. package com.codegym.task.task07.task0716; import java.util.ArrayList; /* R or L */ public class Solution { public static void main(String[] args) throws Exception { ArrayList<String> list = new ArrayList<String>(); list.add("rose"); // 0 list.add("red"); // 1 list.add("love"); // 2 list = fix(list); for (String s: list) { System.out.println(s); } } public static ArrayList<String> fix(ArrayList<String> list) { int j=0; ArrayList<String> list1 = new ArrayList<String>(); //list1.addAll(list); for (int i = 0; i < list.size(); i++) { if (list.get(i).contains("r") && list.get(i).contains("l")) { list1.add(list.get(i)); } else if (list.get(i).contains("r") && !(list.get(i).contains("l"))) continue; else if (!(list.get(i).contains("r")) && list.get(i).contains("l")) { list1.add(list.get(i)); list1.add(list.get(i)); } else { list1.add(list.get(i)); } } return list1; }

Guadalupe Gagnon

Level 37 , Tampa, United States

5 May 2019, 19:09

You have a whole bunch of statements in there that are useless. You could write your sort method like this with the same result:

public static ArrayList<String> fix(ArrayList<String> list) {
      // int j=0;
      ArrayList<String> list1 = new ArrayList<String>();
      //list1.addAll(list);
      for (int i = 0; i < list.size(); i++) {

         /* if (list.get(i).contains("r") && list.get(i).contains("l"))
          {
              list1.add(list.get(i));
          }
          else*/ if (list.get(i).contains("r") && !(list.get(i).contains("l"))) continue;

          else if (!(list.get(i).contains("r")) && list.get(i).contains("l"))
          {
              //list1.add(list.get(i));
              list1.add(list.get(i));
          }
          //else
          //{
              list1.add(list.get(i));
          //}

      }

      return list1;
  }

Guadalupe Gagnon

Level 37 , Tampa, United States

3 May 2019, 20:33

you restricted the loop on line 28 to only three iterations. What if an array list was passed in that had 4 values? 5? 6? 7.....?

dpp

Level 8 , Colombo, Sri Lanka

4 May 2019, 19:12

but in this case i have entered only 3 elements.so will it affect the verification?

Guadalupe Gagnon

Level 37 , Tampa, United States

4 May 2019, 19:19

yes. The main method is not tested, only the fix method which accepts an ArrayList<String>. You have no idea how many elements will be in that ArrayList and should code accordingly.