What am I doing wrong?

Question about the task

Minimum of N numbers

Java Syntax, Level 8, Lesson 11

Under discussion

I am reading from the keyboard to get the N number. Then reading line N times.

1. Use the keyboard to enter the number N.
2. Read N integers and put them in a list: the getIntegerList method.
3. Find the minimum among the list items: the getMinimum method.

Requirements:

The program should display text on the screen.
The program should read values from the keyboard.
The Solution class must have only three methods.
The getIntegerList() method should read the number N from the keyboard and then return a list of N elements, which has been filled with numbers read from the keyboard.
The getMinimum() method must return the minimum among the list items.
The main() method should call the getIntegerList() method.
The main() method should call the getMinimum() method.

package com.codegym.task.task08.task0822; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.*; /* Minimum of N numbers */ public class Solution { public static void main(String[] args) throws Exception { List<Integer> integerList = getIntegerList(); System.out.println(getMinimum(integerList)); } public static int getMinimum(List<Integer> array) { // Find the minimum here int i = array.indexOf(Collections.min(array)); Integer min = array.get(i); return min; } public static List<Integer> getIntegerList() throws IOException { // Create and initialize a list here BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); List<Integer> totatlList = new ArrayList<Integer>(); String s = reader.readLine(); int x = Integer.parseInt(s); for (int i = 0; i < x; i++) { s = reader.readLine(); x = Integer.parseInt(s); totatlList.add(x); } return totatlList; } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Mr Coder

Level 12 , Heywood, United Kingdom

4 March 2021, 01:56

change

x = Integer.parseInt(s)
//you can simply use it one line to save some lines like so
int sx = Integer.parseInt(reader.readLine());

to sx or something else because x is being used as the end loop condition.

Mr Coder

Level 12 , Heywood, United Kingdom

4 March 2021, 01:52

you can simply

return Collections.min(array);

thithin k v

Level 12 , Bangalore, India

26 June 2019, 07:16

You can found out minimum number using iterator method also. public static int getMinimum(List<Integer> array) { Iterator<Integer> itr = array.iterator(); int min = array.get(0); while(itr.hasNext()) { int num = itr.next(); if (min > num ) min = num; } // Find the minimum here return min; } Try this code

Guadalupe Gagnon

Level 37 , Tampa, United States

4 May 2019, 03:14

You are using the variable 'x' as both the break point of the for loop, and user input inside of that same loop. Because the user input changes x every iteration of the loop, unexpected things are occurring. If you enter 10 for N, then enter the numbers 1,2,3,4,5,5 the program will exit at the second entered 5 with 1 being displayed as the min.