help find error please

Question about the task

Under discussion

public class Solution { public static int min(int a, int b, int c) { if (a > b && a > c) if (b > c) return c; else return b; else if (b > a && b >c) if (a > c) return c; else return a; } public static void main(String[] args) throws Exception { System.out.println(min(1, 2, 3)); System.out.println(min(-1, -2, -3)); System.out.println(min(3, 5, 3)); System.out.println(min(5, 5, 10)); } }

package com.codegym.task.task02.task0216; /* Minimum of three numbers */ public class Solution { public static int min(int a, int b, int c) { if (a > b && a > c) if (b > c) return c; else return b; else if (b > a && b >c) if (a > c) return c; else return a; } public static void main(String[] args) throws Exception { System.out.println(min(1, 2, 3)); System.out.println(min(-1, -2, -3)); System.out.println(min(3, 5, 3)); System.out.println(min(5, 5, 10)); } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Khairul

Level 11

10 May 2019, 07:42

The problem is in your logic. You can try this, for example, if a smaller than both b and c then a is the minimum number of the three numbers a, b, c. You can do this in the following logic: If (a <= b && a <= c)then return a. Hope that helps, and remember one thing, do not overthink the problem and try to keep your solution as simple as possible. This way you will have lesser bugs and efficient solution. If you have any more questions, feel free to ask.

Ankita Patra

Level 5 , Bhubaneshwar, India

10 May 2019, 06:41

Try to maintain a proper indentation. Add some curly braces in your if statements. Here is another solution for the code- int m; if(a<=b && a<=c) { m=a; } else if(b<=c) { m=b; } else m=c; return m;

Drei Yan

Level 3 , Taguig, Philippines

10 May 2019, 05:50

public static int min(int a, int b, int c) { if (a > b && a > c) { if (b > c) return c; else return b; } else if (b > a && b >c) { if (a > c) return c; else return a; } }

Drei Yan

Level 3 , Taguig, Philippines

10 May 2019, 05:48

put some curly braces in your if statements