What's wrong?

Question about the task

Long words

Java Core, Level 9, Lesson 11

Resolved

I'm feeling there's some insanely dumb and obvious here, but i cant see it

The main method's first parameter is file1 and the second is file2.
file1 contains words separated by spaces.
Write to file2 a comma-separated list of words longer than 6 characters.
file2 should not end with a comma.
Close the streams.

Example output to file2:
lengthy,shortened,abbreviation

Requirements:

The program must NOT read data from the console.
The program must read the first file's contents (use the FileReader constructor with a String parameter).
The file input stream (FileReader) must be closed.
The program should write to the second file all the words from the first file longer than 6 characters, separated by commas (use FileWriter).
The file output stream (FileWriter) must be closed.

package com.codegym.task.task19.task1925; /*The main method's first parameter is file1 and the second is file2. file1 contains words separated by spaces. Write to file2 a comma-separated list of words longer than 6 characters. file2 should not end with a comma. Close the streams. Example output to file2: lengthy,shortened,abbreviation*/ import java.io.*; public class Solution { public static void main(String[] args) throws IOException { BufferedReader reader = new BufferedReader(new FileReader(args[0])); String[] s = reader.readLine().trim().split(" "); reader.close(); StringBuilder res = new StringBuilder(); for (String word : s) { if (word.length() > 6) { res.append(word).append(','); } } FileWriter writer = new FileWriter(args[1]); writer.write(res.substring(0, res.length() - 1)); writer.close(); } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

15 May 2019, 13:48

The code is clean and works according to my understanding of reading the conditions. Try reading from file1 more than one line.

Dmitrii

Level 38 , Saint Petersburg, Russian Federation

15 May 2019, 14:28

BufferedReader reader = new BufferedReader(new FileReader(args[0]));
        FileWriter writer = new FileWriter(args[1]);
        while (reader.ready()) {
            String[] s = reader.readLine().trim().split(" ");
            StringBuilder res = new StringBuilder();
            for (String word : s) {
                if (word.length() > 6) {
                    res.append(word).append(',');
                }
            }
            writer.write(res.substring(0, res.length() - 1));
            if (reader.ready()) {
                writer.write("\n");
            }
        }
        reader.close();
        writer.close();

now 3 last conditions aren't met

Guadalupe Gagnon

Level 37 , Tampa, United States

15 May 2019, 15:04

solution

The validation system is just a road block to learning sometimes. Many tasks fail for unclear reasons and you just have to keep trying different, sometimes unintuitive, ways to trick it into passing you: Try this:

public class Solution {

        public static void main(String[] args) throws IOException {
            StringBuilder res = new StringBuilder();
            FileReader fr = new FileReader(args[0]);
            BufferedReader reader = new BufferedReader(fr);

            while (reader.ready()) {
                String[] s = reader.readLine().trim().split(" ");

                for (String word : s) {
                    if (word.length() > 6) {
                        res.append(word).append(',');
                    }
                }
            }
            fr.close();
            reader.close();

            FileWriter writer = new FileWriter(args[1]);
            writer.write(res.substring(0, res.length() - 1));
            writer.close();
        }
}

+12

Dawid

Level 28

29 August 2020, 23:32

More than a year has passed and still the same, good solutions are rejected on the pretext of not using FileWriter. Although it is used. It was the same for Task1923. Will I often encounter something like this later in the course? Because for the first time I wonder if it is worth extending the subscription and so far I have been generally satisfied with the course. Is it?