Can't see my mistake

Question about the task

Resolved

I only get one line of output. I revisited each line a couple of times and can't find what's the problem. It only creates one object WhyTheFace?!

1. Change the GenerateThread class to make it a thread.
2. Create a GenerateThread constructor, which must:
2.1. Call the superclass's constructor, passing the created thread's number as a String. Use createdThreadCount.
2.2. Start the current thread.
2.3. The thread numbers must start with 1.
3. Override the toString method: inside GenerateThread, use Alt+Insert -> Override Methods. Start typing "toString".
3.1. The toString method must return the current thread number and the word "created". Use getName().

Example:
8 created

4. If the number of created threads is less than Solution.count, the run method must:
4.1. Create a new GenerateThread.
4.2. Display the thread created in Item 4.1.
5. In the end, 15 lines should be output to the console.

Requirements:

The GenerateThread class should inherit the Thread class.
The GenerateThread class must have a public no-argument constructor.
The GenerateThread class constructor should increment createdThreadCount and pass it as a string to the superclass constructor.
The GenerateThread class constructor must start the thread.
The GenerateThread class's toString method must return the thread name and the word " created". Example: "8 created".
If the number of created threads is less than Solution.count, the run method must create a new GenerateThread.
If the number of created threads is less than Solution.count, the run method must display the created thread.
The program's output must match the task conditions and indicate that all 15 threads have been created.

package com.codegym.task.task16.task1623; /* Creating threads recursively */ public class Solution { static int count = 15; static volatile int createdThreadCount; public static void main(String[] args) { System.out.println(new GenerateThread()); } public static class GenerateThread extends Thread { public GenerateThread() { super(String.valueOf(++createdThreadCount)); start(); } public void run() { if (createdThreadCount < count) { new GenerateThread(); } } @Override public String toString() { return String.format("%s created", getName()); } } }

Comments (6)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

22 May 2019, 17:24

Copy and paste line 13 to line 26

Darko Jakimovski

Level 18 , Kriva Palanka, Macedonia, The Former Yugoslav Republic of

22 May 2019, 17:32

I did it and it passed. But I don't get why didn't it print out all of the object before :/ Thanks man

Darko Jakimovski

Level 18 , Kriva Palanka, Macedonia, The Former Yugoslav Republic of

22 May 2019, 17:33

Is it because the sout only prints out one time and that one object? I think that's the answer :)

Guadalupe Gagnon

Level 37 , Tampa, United States

22 May 2019, 17:36

Yes. The other ones were being created in the background but nothing was calling the toString() method on them like the very first one.

The Chief

Level 18 , United States

27 July 2021, 23:22

G, my code is almost the exact same as this guy's but I'm getting a whole bunch of weird errors in my toString method. Do you know why? But when I copy and paste the GenerateThread class from here on to my IntelliJ, it works. It's very strange. This is my code by the way:

public class Solution {
    static int count = 15;
    static volatile int createdThreadCount;

    public static void main(String[] args) {
        System.out.println(new GenerateThread());

    }

    public static class GenerateThread extends Thread{

        public GenerateThread(){

           super(Integer.toString(createdThreadCount++));
            start();
        }

        public void run(){
            if (createdThreadCount < count){
                System.out.println(new GenerateThread());

            }

            @Override
            public String toString() {
                return String.format("%s created", getName());
            }



        }
    }
}

Guadalupe Gagnon

Level 37 , Tampa, United States

28 July 2021, 13:17

With this code the closing bracket at line 31 should be at line 23 instead. The way that the code is written, your toString() method is inside the run() method.