CodeGym
CodeGym University
Learning
Course
Tasks
Surveys & Quizzes
Games
Help
Schedule
Community
Users
Forum
Chat
Articles
Success stories
Activity
Reviews
Subscriptions
Light theme
Question
  • Reviews
  • About us
Start
Start learning
Start learning now
  • All questions
arun et
Level 11
Chennai
  • 03.06.2019
  • 816views
  • 2comments

works fine, output is as expected. but still 1 condition not satisfied; pls help

Question about the task Task about algorithms
Java Syntax,  Level 5,  Lesson 12
Archived


Write a program that:
1. reads a number N (must be greater than 0) from the console
2. reads N numbers from the console
3. Displays the maximum of the N entered numbers.

Requirements:
  • The program should read the numbers from the keyboard.
  • The program must display a number on the screen.
  • The class must have a public static void main method.
  • Don't add new methods to the Solution class.
  • The program should display the maximum of the N entered numbers.
  • The program should not display anything if N is less than or equal to 0.
package com.codegym.task.task05.task0532; import java.io.*; /* Task about algorithms */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int maximum = 0; int N = Integer.parseInt(reader.readLine()); if(N>0){ int v[] = new int[N]; for(int a=0;a<N;a++){ v[a] = Integer.parseInt(reader.readLine()); } for(int i=0;i<N;i++){ if(v[i] > maximum){ maximum = v[i]; } } System.out.println(maximum); } else{ System.out.println("please enter a positive value"); } } }
0
Comments (2)
  • Popular
  • New
  • Old
You must be signed in to leave a comment
Guadalupe Gagnon
Level 37 , Tampa, United States
3 June 2019, 18:59useful
maximum should not be set to an initial value of zero. What if I have 3 numbers: -15, -2, -8 The max of those would be -2... the above code would output 0. You need to fix this.
+1
arun et
Level 11 , Chennai, India
3 June 2019, 20:50
thank you! makes sense now, least value possible (MIN_VALUE) should be set to maximum right.
+1
Learn
  • Registration
  • Java Course
  • Help with Tasks
  • Pricing
  • Game Projects
  • Java Syntax
Community
  • Users
  • Articles
  • Forum
  • Chat
  • Success Stories
  • Activity
  • Affiliate Program
Company
  • About us
  • Contacts
  • Reviews
  • Press Room
  • CodeGym for EDU
  • FAQ
  • Support
CodeGym CodeGym is an online course for learning Java programming from scratch. This course is a perfect way to master Java for beginners. It contains 1200+ tasks with instant verification and an essential scope of Java fundamentals theory. To help you succeed in education, we’ve implemented a set of motivational features: quizzes, coding projects, content about efficient learning and Java developer’s career.
Follow us
Interface language
Programmers Are Made, Not Born © 2023 CodeGym
MastercardVisa
Programmers Are Made, Not Born © 2023 CodeGym
This website uses cookies to provide you with personalized service. By using this website, you agree to our use of cookies. If you require more details, please read our Terms and Policy.