R or L = troubles;

Question about the task

Under discussion

Can anyone please let me know what is wrong with my code? I don't necessarily want a solution, just wanna understand why do i get the "java heap space " error and how to fix it. Thank you in advance

1. Create a list of words and populate it yourself.
2. The fix method should:
2.1. remove all words containing the letter "r" from the list
2.2. duplicate all words containing the letter "l".
2.3. if a word contains both "r" and "l", then leave it unchanged.
2.4. don't do anything to other words.

For example:
rose lyre love

Output:
lyre love love

Requirements:

The program must not read data from the keyboard.
The fix method should remove all words containing the letter "r" from the list. There is an exception: words containing both "r" and "l" should be left alone.
The fix method must duplicate words containing the letter "l" (add another instance of this word to the list). There is an exception: words containing both "l" and "r" should not be duplicated.
The fix method should not do anything with words that contain both "l" and "r".
The fix method should not do anything with words that don't contain either "l" or "r".

package com.codegym.task.task07.task0716; import java.util.ArrayList; /* R or L */ public class Solution { public static void main(String[] args) throws Exception { ArrayList<String> list = new ArrayList<String>(); list.add("love"); // 0 list.add("lyre"); // 1 list.add("love"); // 2 list.add("measure"); list.add("mustacher"); list = fix(list); for (String s : list) { System.out.println(s); } } public static ArrayList<String> fix(ArrayList<String> list) { // write your code here ArrayList<String> list1 = new ArrayList<>(); for(String x : list ) { if (!x.contains("r") && x.contains("l")) { list1.add(x); } else if (x.contains("r") && x.contains("l")) { list1.add(x); } } for(int i = 0; i < list1.size(); i++){ if(!list1.get(i).contains("r")){ list1.add(list1.get(i)); } } return list1; } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Deep Maheshwari

Level 10 , Nanded, India

2 July 2019, 11:48

Instead of using for each loop in the code , Use for (int i=0;i<list.size;i+=1) Since after adding elements the loop will also go through added elements.

Djole

Level 41 , Belgrade, Serbia

1 July 2019, 22:25

the problem i see is i < list1.size(); in for loop (line 35), since by adding elements to it size of the list is increasing. you should use fixed size i.e define int n = list1.size(); before the loop and then use i < n; in the loop and you should be okay. one question tho, why didn't you simply use list1.add(x); twice (line 30) and avoid lines 35 - 39?