CodeGym/Help with Java Tasks/Not sure what is wrong with this modified code - this che...

Level 8

Bangalore

14.09.2018
2023views
15comments

Not sure what is wrong with this modified code - this checks for equal conditions as well!

Question about the task

Implement the fight method

Java Syntax, Level 5, Lesson 5

Resolved

Implement the boolean fight(Cat anotherCat) method:
implement a mechanism for cats to fight based on their weight, age and strength.
You can decide for yourself how a cat's characteristics factor into combat.
The method should determine whether we (this) won the fight, i.e. return true if we won and false if not.

The following condition must be met:
if cat1.fight(cat2) returns true,
then cat2.fight(cat1) must return false

Requirements:

The Cat class must have a constructor with no parameters.
The Cat class must contain public fields age, weight, and strength.
The Cat class must have a fight method.
In the fight method, implement a mechanism for cats to fight based on their weight, age and strength.
The method should return the same value every time we fight the same cat.
If cat1 beats cat2, then cat2 must lose to cat1.

package com.codegym.task.task05.task0502; /* Implement the fight method */ public class Cat { public int age; public int weight; public int strength; String name; public Cat() { } public boolean fight(Cat anotherCat) { boolean won = false; if ((this.strength > anotherCat.strength) || (this.weight > anotherCat.weight) || (this.age < anotherCat.age)) won = true; else if ((this.strength == anotherCat.strength) && (this.weight == anotherCat.weight) && (this.age == anotherCat.age) && (this.name == "Favorite cat")) won = true; return won; } public static void main(String[] args) { Cat cat1 = new Cat(); Cat cat2 = new Cat(); cat1.age = 4; cat1.weight = 24; cat1.strength = 98; cat1.name = "Favorite cat"; cat2.age = 4; cat2.weight = 24; cat2.strength = 99; cat2.name = "Unknown cat"; System.out.println(cat1.fight(cat2)); System.out.println(cat2.fight(cat1)); } }

Comments (15)

Popular
New
Old

You must be signed in to leave a comment

fady shaker

Level 7 , Stuttgart, Germany

20 March 2019, 14:50

/* The comment was deleted */

vikr@nt

Level 9 , Cincinatti , United States

31 January 2019, 02:35

Wonderwoman you have declared one more member variable or instance variable i.e. String name; which is not required The logic can be implemented this way too int i=this.weight+this.strength+this.age; int j=anotherCat.age+anotherCat.weight+anotherCat.strength; After this increment and decrement the value of i and j based on the comparison of attributes and if both value of a particular attribute are equal then decrement i as well as j. So in this case if all the member variable are equal then 6th condition will verify too Remember that 6th condition includes 'if' If cat1 beats cat2, then cat2 must lose to cat1. i.e. if the evaluation is true. But evaluation can be false too hence verification won't complain. i.e. if all the attributes are equal i.e. if inti = 20 and intj=20 by adding all the attributes then i>j wont be satisfied and switch to else which is false.

Norbert

Level 8 , Budapest, Hungary

27 March 2019, 18:37

Thank you. You helped a lot in this task. :)

rajesh

Level 10

10 January 2019, 11:47

/* The comment was deleted */

vikr@nt

Level 9 , Cincinatti , United States

31 January 2019, 02:37

Why you have to declare one more instance variable Rajesh. You can add the attributes of particular cat and assign them to two local variables in the fight method isn't ?

Muhammad Asad

Level 9 , Gujranwala, Pakistan

22 September 2018, 14:41

try this in the fight method if(this.age > anotherCat.age || this.weight > anotherCat.weight || this.strength > anotherCat.strength ){ return true; }else return false;

-1

Muhammad Yasir

Level 5 , Islamabad, Pakistan

26 April 2019, 17:39

Buddy you have provided the most compact way of solving the code puzzle... thanks issue resolved

Learner

Level 16 , India

18 September 2018, 05:12

The idea is to have point system. For example, if Cat a is older than Cat b then Cat a gets 1 point and so on. Any Cat whose total points are more will win.

WonderWoman

Level 8 , Bangalore, India

18 September 2018, 05:58

But it will fail for a case where all the 3 parameters are same for both the cats. Per the condition list, if one cat wins, the other has to lose - this condition will fail in this situation where both cats win or lose, not one of them. Hence added the buffer parameter of name to take care of this specific condition.

Khurram

Level 16 , Lahore, Pakistan

18 September 2018, 10:18

points system would give the same total for both the cats if their variable values are the same, the problem is how do you ensure that when cat 1 fights cat 2 it returns result and when cat 2 fights cat 1 it returns !result

Learner

Level 16 , India

19 September 2018, 05:18

Well, if all the characteristics of both cats are the same, then you can not predict the outcome. What if the name of both the cats is also the same? That is the not the point of this exercise. You have to write the logic with the assumption that all 3 characteristics are not the same.

WonderWoman

Level 8 , Bangalore, India

19 September 2018, 06:43

As per the requirement #6, if cat1 wins over cat2, cat2 must lose to cat1. Also, nowhere in the requirements has it been mentioned that both the cats cannot have the same characteristics (which they totally can). The same code of <= basic checks was earlier erroring out on #6 (saw Roman ask some learner to try 4, 24 and 99 for both cats and then try some other code addition), now it works. Requirement #6 needs to be edited to add your assumption listed since the code now compiled correctly even with both options returning true OR both returning false; which would essentially negate #6.

Learner

Level 16 , India

19 September 2018, 06:52

Try this example: cat1.age = 4; cat1.weight = 10; cat1.strength = 98; cat1.name = "Favorite cat"; cat2.age = 3; cat2.weight = 25; cat2.strength = 90; cat2.name = "Unknown cat";

WonderWoman

Level 8 , Bangalore, India

17 September 2018, 05:34

yes, to accomodate for the condition where all the 3 characteristics are same, and still one cat should win and another should lose; I have added the name as well. Otherwise the output would be true and true or false and false which will miss one of the listed criteria.

Khurram

Level 16 , Lahore, Pakistan

14 September 2018, 11:04

I'm stuck with this as well, but the issue I can see here is that Cat class should have age, weight and strength variables, name is not mentioned in the problem. Also the name could be anything, you have hard-coded for "Favorite Cat"