Can anyone see where the bug is?

Question about the task

Under discussion

The task fails the last three checks, but I'm unclear why the last two fail; I do call countMineNeighbors() at the end of createGame() and I use getNeighbors(...) in the countMineNeighbors() method. I cannot figure out where I am counting neighboring mines for a cell that is also a mine.

if (!cell.isMine) {

on line 104 should be handling that.

Now let's count the mines in adjacent cells. To do this, we'll add a field to each cell of the matrix, which will be responsible for the number of mined neighbors. First, we find all the neighbors, and then we count how many of them are mined.

To get the list of neighbors, you now have the getNeighbors() method, which has one GameObject (cell) parameter.

Your task is to, in a separate method, count the number of mined neighbors for each cell in gameField and assign this value to the appropriate field of the cell.

Although your work is not visible (you started program to see what happens, right?), it is very important to future steps.

Requirements:

The GameObject class must have a public int countMineNeighbors field.
The MinesweeperGame class must have a private void countMineNeighbors() method.
The countMineNeighbors() method should, for each non-mined cell in the gameField matrix, count the number of adjacent mined cells and assign this value to the countMineNeighbors field.
The countMineNeighbors() method should use the getNeighbors(GameObject gameObject) method.
In the createGame() method, after all the elements of the gameField matrix are created, the countMineNeighbors() method must be called.

package com.codegym.games.minesweeper; public class GameObject { public int x; public int y; public boolean isMine; public int countMineNeighbors; public GameObject(int x, int y, boolean isMine) { this.x = x; this.y = y; this.isMine = isMine; } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Andreea

Level 9 , United Kingdom

23 July 2019, 16:51

if (!gameField[i][j].isMine) { GameObject gameObject = gameField[i][j]; getNeighbors(gameObject); }

Andreea

Level 9 , United Kingdom

23 July 2019, 16:48

private void createGame() { for(int i = 0; i < SIDE; i++) for(int j = 0; j < SIDE; j++) { int rn = getRandomNumber(10); if(rn == 1 && countMinesOnField < 10) { gameField[i][j] = new GameObject(i, j,true ); countMinesOnField ++; } else { gameField[i][j] = new GameObject(i, j, false); } } countMineNeighbors(); }