Passed but is it correct way of programing?

Question about the task

Under discussion

ArrayList<String> list = new ArrayList<String>();
       Collections.addAll(list,"Sam","Ham", "I","Ham", "Am", "Ham");

       for (int i = 0; i < list.size() ; i++) {
           System.out.println(list.get(i));
       }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

BTu4-man

Level 1

28 July 2019, 23:23

No. It's called hard-coding. For example, you have a task: for provided two Strings "anna", "maria": 1. convert them to UpperCase 2. combine them and print to console. What's expected from you:

string1 = string1.toUpperCase();
string2 = string2.toUpperCase();
System.out.println(string1 + string2);

How is harc-coding looks like:

System.out.println("ANNAMARIA");

It's not a solution at all. You just do code in your mind, and write result to the code. but instead your code should compute right answer. So.

ArrayList<String> list = new ArrayList<String>();

it's ok. Then:

list.add("Sam");
list.add("I");
list.add("Am");
OR
Collections.addAll(list,"Sam", "I", "Am");
OR directly
ArrayList<String> list = new ArrayList<>(Arrays.asList("Sam","I","Am"));

Then you have loop:

for (int i = 0; i < list.size() ; smth interesting could be there) {
       ...
}

There you could add new elements to the list. And after that - just print out the list to a console. Smth like that. Even if it was passed, it's better to change and solve it in the right way.