solution is not verified.

Question about the task

Under discussion

Can anyone point it out why?

Read 2 file names from the console.
Output to the second file all of the numbers from the first file.
Separate the numbers with a space.
Close the streams.

Example file content:
12 text var2 14 8v 1

Result:
12 14 1

Requirements:

The program should read file names from the console (use BufferedReader).
The BufferedReader used for reading input from the console must be closed after use.
The program must read the first file's contents (use the BufferedReader constructor that takes a FileReader argument).
The file input stream (BufferedReader) must be closed.
The program must write all of the numbers from the first file, separated by spaces, to the second file (use the BufferedWriter constructor that takes a FileWriter argument).
The file output stream (BufferedWriter) must be closed.

package com.codegym.task.task19.task1908; /* Picking out numbers */ import java.io.*; import java.io.IOException; import java.util.ArrayList; public class Solution { public static void main(String[] args) throws IOException { BufferedReader br = new BufferedReader(new InputStreamReader(System.in)); String inputFile = br.readLine(); String outputFile = br.readLine(); br.close(); FileReader reader = new FileReader(inputFile); FileWriter writer = new FileWriter(outputFile); br = new BufferedReader(reader); BufferedWriter bw = new BufferedWriter(writer); ArrayList<Integer> fileNumbers = new ArrayList<>(); String line = br.readLine(); while( line != null){ String[] lineArr = line.split(" "); for(int i = 0; i < lineArr.length; i++){ try{ int n = Integer.parseInt(lineArr[i].trim()); fileNumbers.add(n); }catch(Exception e){ } } //bw.write(resultedLine); line = br.readLine(); } for(int num : fileNumbers){ bw.write(num + "\t"); //bw.write(" "); } bw.close(); br.close(); reader.close(); writer.close(); } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Nithin

Level 35 , Hyderabad, India

28 August 2019, 04:16

I think the problem is that you need to write numbers separated by a space character but instead you are writing numbers separated by 5 space characters. Change line 44.

Rupa Joshi

Level 29 , Tokyo, Japan

28 August 2019, 05:15

I added that when nothing worked.If you can see the line with write(" ") this way I was trying to add the space. Any better way to add a space after every number?

Nithin

Level 35 , Hyderabad, India

28 August 2019, 08:43

I ran your code. The problem is it is printing ascii values of 12, 14 and 1 instead of printing 12 , 14 and 1 as integers. This happens because when you pass an integer as the parameter to the write method it will take it as a byte value. If you want to pass an integer you should pass it as a string like

// Recommended
bw.write(num + " ");
//Not recommended
bw.write(num);
bw.write(" ");

And if it is still not passing the test it may be because of extra space character we are adding for the last integer in the loop.Then try like this

StringBuilder sb = new StringBuilder();
        for(int num : fileNumbers){
           sb.append(num).append(" ");
        }
        sb.deleteCharAt(sb.length() - 1);
        bw.write(sb.toString()); //writing all at once as a string

Rupa Joshi

Level 29 , Tokyo, Japan

28 August 2019, 09:14

Thanks it worked. Completely forgotten about write method with Integer. thanks a lot