Everything looks right and yet I'm somehow not accounting for all mined neighbors, please help! Thanks in advance

Question about the task

Resolved

NOTE: Ignore the MinesweeperGame.class file, that's now how it's showing on my end so I'm not really sure what's going on there. So I've checked everything at this point and my code seems to be correct. I accounted for the fact that the columns and the cells are swapped here:

for (int y = 0; y < SIDE; y++) {
    for (int x = 0; x < SIDE; x++) {
        GameObject currentCell = gameField[x][y];

so that shouldn't be the issue. I've performed several tests and it all looks correct. What am I missing?

Now let's count the mines in adjacent cells. To do this, we'll add a field to each cell of the matrix, which will be responsible for the number of mined neighbors. First, we find all the neighbors, and then we count how many of them are mined.

To get the list of neighbors, you now have the getNeighbors() method, which has one GameObject (cell) parameter.

Your task is to, in a separate method, count the number of mined neighbors for each cell in gameField and assign this value to the appropriate field of the cell.

Although your work is not visible (you started program to see what happens, right?), it is very important to future steps.

Requirements:

The GameObject class must have a public int countMineNeighbors field.
The MinesweeperGame class must have a private void countMineNeighbors() method.
The countMineNeighbors() method should, for each non-mined cell in the gameField matrix, count the number of adjacent mined cells and assign this value to the countMineNeighbors field.
The countMineNeighbors() method should use the getNeighbors(GameObject gameObject) method.
In the createGame() method, after all the elements of the gameField matrix are created, the countMineNeighbors() method must be called.

package com.codegym.games.minesweeper; public class GameObject { public int x; public int y; public boolean isMine; public int countMineNeighbors; public GameObject(int x, int y, boolean isMine) { this.x = x; this.y = y; this.isMine = isMine; } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

ddi

Level 18 , Dortmund, Germany

12 September 2019, 08:03

In line 39 have you tried !gameField instead of !currencell?

Pavlo Plynko Java Developer at CodeGym

9 September 2019, 07:28

solution

There is getNeighbors ready-made method:

private List getNeighbors(GameObject gameObject) {
    List result = new ArrayList<>();
    for (int y = gameObject.y - 1; y <= gameObject.y + 1; y++) {
        for (int x = gameObject.x - 1; x <= gameObject.x + 1; x++) {
            if (y < 0 || y >= SIDE) {
                continue;
            }
            if (x < 0 || x >= SIDE) {
                continue;
            }
            if (gameField[y][x] == gameObject) {
                continue;
            }
            result.add(gameField[y][x]);
        }
    }
    return result;
}

I don’t know where exactly the error is in your implementation, try to find it yourself.

Alesha Ray

Level 20 , Austin, United States

11 September 2019, 00:52

Thanks, I couldn't find the ready made method. I'll see where my method goes wrong and if I can't find it, I'll use this one.