Help me whats wrong here

Question about the task

Take your turn!

Java Core, Level 6, Lesson 13

Under discussion

whts wrong

1. In the Solution class, create a public static Read3Strings class that inherits Thread.
2. In the run method, read three lines from the console.
3. Three lines should be read in succession on one thread and combined into one space-delimited string.
4. In the main method, display the result for each thread.
5. Use join.

Example:

Input:
a b c d e f

Output:
a b c d e f

Requirements:

In the Solution class, declare the public static Read3Strings class.
The Read3Strings class should inherit the Thread class.
The Read3Strings class's run method must read three lines.
The Read3Strings class must have a public printResult method.
The printResult method should display the 3 read lines, separating them with spaces.
The main method should call the created threads' start methods.
The main method should call the created threads' join methods.
The program's output should indicate that the threads read the lines sequentially, not in parallel.

package com.codegym.task.task16.task1629; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.*; public class Solution { public static volatile BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); public static void main(String[] args) throws InterruptedException { Read3Strings t1 = new Read3Strings(); Read3Strings t2 = new Read3Strings(); //write your code here t1.start(); t2.start(); t1.join(); t2.join(); t1.printResult(); t2.printResult(); } //write your code here public static class Read3Strings extends Thread{ ArrayList<String> list = new ArrayList<>(); public void run(){ try{ for(int i=0; i<3; i++){ list.add(reader.readLine()); } }catch(Exception e){ e.printStackTrace(); } } public String printResult(){ return String.format("%s %s %s", list.get(0), list.get(1), list.get(2)); } } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

hanumohan

Level 25 , San Jose, United States

3 May 2020, 15:49

issues was your not printing any thing ,first take your code line 21 -22 and 39-41, 1. you are not print anything because you return string format

Sytem.out.println(t1.printResult());
Sytem.out.println(t2.printResult());

public String printResult(){
           return String.format("%s %s %s", list.get(0), list.get(1), list.get(2));
       }

But actually our requirement we can change only Read3String class, you can change

public void printResult()
{
for(int i = 0; i < list.size; i++){
System.out.print(list.get(i))
}
System.out.println();
}

Johannes

Level 27 , Centurion, Pretoria, South-Africa

2 April 2020, 09:52

First do the join on your first thread, before starting your second thread.

Hossein Shams

Level 26 , Atlanta, United States

9 September 2019, 22:52

Remember that "join" method of a thread object makes other threads to wait for that specific thread to finish and then start or continue running. Here your threads are running simultaneously. You need to use join method somewhere that makes the second thread wait until the first thread finishes its work. Also, your calls to the "printResult" method are printing both strings on the same line. Make sure to add a linefeed character or call for an empty println method between two lines. You'll probably figure it out, but if you still had difficulties getting it resolved, reply to this comment. Best