My code works but doesn't verify, help me please

Question about the task

Under discussion

I've tried several tests on IntelliJ and they all worked as expected: Input: 3, 3, 3; Output: 3 Input: 3, 3, 4; Output: 3 Input: 3, 4, 5; Output: 4 Don't understand what I got wrong :( Any help would be much appreciated!

package com.codegym.task.task04.task0441; /* Somehow average */ import java.io.*; import java.util.Scanner; public class Solution { public static void main(String[] args) throws Exception { Scanner sc = new Scanner(System.in); int n1 = sc.nextInt(), n2 = sc.nextInt(), n3 = sc.nextInt(); int d12 = n1 - n2, d13 = n1 - n3; if (d12 * d13 <= 0) { System.out.println(n1); } else if (Math.abs(d12) <= Math.abs(d13)) { System.out.println(n2); } else System.out.println(n3); } }

Comments (7)

Popular
New
Old

You must be signed in to leave a comment

Mike McKenna

Level 25 , Wilmington, United States

19 September 2019, 22:18

Hi, i am not very familiar with using over loading Math abs. i went to java complete reference 9th edition Herbert Schildt . on page 132 following sentences . The value of overloading is that it allows related methods to be accessed by use of a common name .abs represents this general action that is being performed . It is left to the compiler to choose the right specific version for a particular circumstance . giving control to the compiler is a possible reason. also when Scanner class was introduced in Code Gym it was viewed as having limited uses . i have used Scanner class before found this to be true . i hope this helps

Mike McKenna

Level 25 , Wilmington, United States

18 September 2019, 16:48

Hi, i divided task into 2 parts . sort numbers then compare . i used 2 resources to solve task . stack exchange code review . intro to java programming 9th edition Daniel Lians.

import java.io.BufferedReader;
import java.io.InputStreamReader;
public class Solution {
    public static void main(String[] args) throws Exception {
         BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
        int a = Integer.parseInt(reader.readLine());
        int b = Integer.parseInt(reader.readLine());
        int c = Integer.parseInt(reader.readLine());
 if(a >b) {
            int temp = a;
            a = b;
            b = temp;
        }
    if(b >c) {
            int temp = b;
            b = c;
            c = temp;
        }

        if(a >b) {
            int temp = a;
            a = b;
            b = temp;
   }

        System.out.println(b);

i hope this helps

Xuecong Liu

Level 7 , Australia, China

19 September 2019, 09:29

Hi Mike, thanks for your help. I like your method, it's a good method to avoid using too many 'if's :) Can you please have a look at my method too? I only used two 'if's and it works fine... I don't understand why the validation said it's wrong:

Scanner sc = new Scanner(System.in);
int n1 = sc.nextInt(), n2 = sc.nextInt(), n3 = sc.nextInt();
int d12 = n1 - n2, d13 = n1 - n3; //Calculate the differences between n1, n2; and n1, n3

/*
If d12 * d13 < 0, n1 is the middle number, print n1.
If d12 * d13 = 0, i.e., n1 equals either of n2 and n3, print n1.
If d12 * d13 > 0, n2 and n3 are both bigger or both smaller than n1. In this case, the closer one to n1 is the middle one.
*/

if (d12 * d13 <= 0) {
    System.out.println(n1);
} else if (Math.abs(d12) <= Math.abs(d13)) {
    System.out.println(n2);
} else
    System.out.println(n3);

Cristian

Level 16 , Bucharest, Romania

18 September 2019, 05:25

package com.codegym.task.task04.task0441; import java.util.Scanner; public class Solution { public static void main(String[] args) throws Exception { Scanner scan = new Scanner(System.in); int a = scan.nextInt(); int b = scan.nextInt(); int c = scan.nextInt(); if (a==b || a==c) System.out.print(a); else if (c==b) System.out.print(b); else if (b > a && b < c) System.out.print(b); else if (a > b && a < c) System.out.print(a); else if (b < a && b > c) System.out.print(b); else if (a < b && a > c) System.out.print(a); else System.out.print(c); } }

Xuecong Liu

Level 7 , Australia, China

18 September 2019, 06:08

Thanks for your reply! I understand this method and have no problem using it to pass the task. However, I still want to know why the method I used didn't pass -- its code is much more economical and it seems to be working theoretically and practically. Can you have a look at my code please?

Cristian

Level 16 , Bucharest, Romania

18 September 2019, 10:20

Sorry!

Xuecong Liu

Level 7 , Australia, China

17 September 2019, 15:25

Here is how I designed the algorithm:

Scanner sc = new Scanner(System.in);
int n1 = sc.nextInt(), n2 = sc.nextInt(), n3 = sc.nextInt();
int d12 = n1 - n2, d13 = n1 - n3; //Calculate the differences between n1, n2; and n1, n3

/*
If d12 * d13 < 0, n1 is the middle number, print n1.
If d12 * d13 = 0, i.e., n1 equals either of n2 and n3, print n1.
If d12 * d13 > 0, n2 and n3 are both bigger or both smaller than n1. In this case, the closer one to n1 is the middle one.
*/

if (d12 * d13 <= 0) {
    System.out.println(n1);
} else if (Math.abs(d12) <= Math.abs(d13)) {
    System.out.println(n2);
} else
    System.out.println(n3);