Code does the job, altgough task requirements are not met, anyone know why?

Question about the task

Shortest or longest

Java Syntax, Level 7, Lesson 6

Under discussion

Please help, anyone know why task requirements are not met? Thanks.

1. Create a list of strings.
2. Add 10 strings from the keyboard.
3. Find out which string occurs earlier in the list: the shortest or the longest.
If several strings are shortest or longest, then consider the very first such string encountered.
4. Display the string described in Step 3. One string should be displayed.

Requirements:

Declare a string list variable and immediately initialize it.
The program should read 10 strings from the keyboard and add them to the list.
The program should display the shortest string if it comes before the longest.
The program should display the longest string if it comes before the shortest.

package com.codegym.task.task07.task0712; import java.io.BufferedReader; import java.io.IOException; import java.io.InputStreamReader; import java.util.ArrayList; /* Shortest or longest */ public class Solution { public static void main(String[] args) throws Exception { //write your code here ArrayList<String> list = new ArrayList(); BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); for(int i=0;i<10;i++){ list.add(reader.readLine()); } int s=list.get(1).length(); for(int i=0;i<list.size();i++){ if(s>list.get(i).length()) s=list.get(i).length(); } int l=list.get(1).length(); for(int i=0;i<list.size();i++){ if(l<list.get(i).length()) l=list.get(i).length(); } for(int i=0;i<list.size();i++){ if(s==list.get(i).length() || l==list.get(i).length()) System.out.println(list.get(i)); break; } } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

Vafa

Level 30 , Orumiyeh, Iran, Islamic Republic of

18 September 2019, 18:59

break; is not inside if condition. It should be like this: (from line 31)

for(int i=0;i<list.size();i++){
            if(s==list.get(i).length() || l==list.get(i).length()) {
                      System.out.println(list.get(i));
                      break;
            }
        }