Code appears to be working, but is not passing last two tests

Question about the task

Archived

I have written this several ways, and each produced the results asked for, but it isn't passing the last two tests. Any feedback on why this is?

1. Initialize the list of strings.
2. Read 5 strings from the keyboard and add them to this list.
3. Using a loop, find the longest string in the list.
4. Display the string. If there is more than one, display each on a new line.

Requirements:

In the main method, initialize the Solution class's existing strings field to a new ArrayList<>.
The program should read 5 strings from the keyboard and write them to the list of strings.
The program should display the longest string.
If several strings qualify as the longest, then you need to display each of them on a new line.

package com.codegym.task.task07.task0708; import java.io.BufferedReader; import java.io.InputStreamReader; import java.util.ArrayList; import java.util.List; /* Longest string */ public class Solution { private static List<String> strings; public static void main(String[] args) throws Exception { //write your code here InputStreamReader iReader = new InputStreamReader(System.in); BufferedReader bReader = new BufferedReader(iReader); strings = new ArrayList<>(); int longest = 0; // ArrayList<Integer> longestI = new ArrayList<>(); for (int i = 0; i < 5; i++) { String thisString = bReader.readLine(); strings.add(thisString); } for (int i = 0; i < strings.size(); i++) { if (strings.get(i).length() >= longest) { longest = strings.get(i).length(); System.out.println(strings.get(i)); } } } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Luis Rodriguez Ugarte

Level 22 , Chatillon-sur-Chalaronne, France

19 September 2019, 14:34

solution

Hi, if you try with this values : Input data: a b c d ed ...the output will be: a b c d ed. I use a different approach for solve this problem. First I use an int array to save the string lenght from the ArrayList. Then I sort it out so I got the string lenght in descending order. Then I do a loop to compare each value of the arraylist to the maximum lenght of the in array. So each string that match the maximum lenght will be printed.

int[] stringLenght = new int[strings.size()];

for (i=0; i < strings.size() ; i++){
    stringLenght[i] = strings.get(i).length;
}
// sort in ascending order ..stringLenght[0] will be the minimum value and the last index will be the maximum..
Arrays.sort(stringLenght);
//then do a loop to compare each value of the Arraylist with the maximum value from the int array

Hope it helps :)

Jason Macias

Level 16 , New Jersey, United States

19 September 2019, 15:27

It did help very, thank you. I appreciate it :-)