code failing last three requirements, can you see why this might be?

Question about the task

Under discussion

This code results in failed tests telling me that the countMineNeighbors() method is setting neighbor the countMineNeighbors for objects that are flagged as mines, but I don't see why this would be happening. On line 37 I have an if statement that should only do that if the object is not flagged as a mine. Can anyone see what the problem is with this code?

Now let's count the mines in adjacent cells. To do this, we'll add a field to each cell of the matrix, which will be responsible for the number of mined neighbors. First, we find all the neighbors, and then we count how many of them are mined.

To get the list of neighbors, you now have the getNeighbors() method, which has one GameObject (cell) parameter.

Your task is to, in a separate method, count the number of mined neighbors for each cell in gameField and assign this value to the appropriate field of the cell.

Although your work is not visible (you started program to see what happens, right?), it is very important to future steps.

Requirements:

The GameObject class must have a public int countMineNeighbors field.
The MinesweeperGame class must have a private void countMineNeighbors() method.
The countMineNeighbors() method should, for each non-mined cell in the gameField matrix, count the number of adjacent mined cells and assign this value to the countMineNeighbors field.
The countMineNeighbors() method should use the getNeighbors(GameObject gameObject) method.
In the createGame() method, after all the elements of the gameField matrix are created, the countMineNeighbors() method must be called.

package com.codegym.games.minesweeper; import com.codegym.engine.cell.*; public class MinesweeperGame extends Game { private static final int SIDE = 9; private GameObject[][] gameField = new GameObject[SIDE][SIDE]; private int countMinesOnField; public void initialize() { setScreenSize(SIDE, SIDE); createGame(); }; private void createGame() { for (int i =0; i<gameField.length; i++){ for(int j = 0; j < gameField[i].length; j++){ boolean hasMine = false; if (getRandomNumber(10) < 1){ hasMine = true; countMinesOnField++; } gameField[i][j] = new GameObject(j, i, hasMine); } countMineNeighbors(); } for (GameObject[] a : gameField) { for(GameObject b : a) { setCellColor(b.x, b.y, Color.BLUE); } } } private void countMineNeighbors() { for(GameObject[] x : gameField) { for (GameObject y : x){ if (!y.isMine) { y.countMineNeighbors = getNeighbors(y); } } } } private int getNeighbors(GameObject g) { int count = 0; int[][] neighbors = new int[3][3]; int xStart = g.x -1; int yStart = g.y -1; for (int[] row : neighbors){ for (int cell : row) { if (yStart >= 0 && xStart >=0) { if (gameField[xStart][yStart].isMine) { count++; } } yStart++; } xStart++; } return count; } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

Roman

Level 41

11 October 2019, 11:31

useful

Why did you change the getNeighbors method?

private List getNeighbors(GameObject gameObject) {
        List result = new ArrayList<>();
        for (int y = gameObject.y - 1; y <= gameObject.y + 1; y++) {
            for (int x = gameObject.x - 1; x <= gameObject.x + 1; x++) {
                if (y < 0 || y >= SIDE) {
                    continue;
                }
                if (x < 0 || x >= SIDE) {
                    continue;
                }
                if (gameField[y][x] == gameObject) {
                    continue;
                }
                result.add(gameField[y][x]);
            }
        }
        return result;
    }