Looks like it is working correctly at first glance

Question about the task

John Johnson

Java Core, Level 9, Lesson 11

Under discussion

Could some1 give some tip?

The first parameter of the main method is a file name.
Each line of the specified file has the following format:
name month day year
where [name] is a String that can contain several words separated by spaces.
[month] is an int, [day] is an int, and [year] is an int.
The data is separated by spaces.

Fill the PEOPLE list using the file's data.
Close the streams.

Example input file:
John Jack Johnson 12 31 1987 Vincent 5 15 2013

Requirements:

The Solution class must contain a public List<Person> constant called PEOPLE, which must be initialized immediately.
The program must NOT read data from the console.
The program must read the file's contents (use FileReader).
The file input stream (FileReader) must be closed.
The program must fill the PEOPLE list with data from the file.
The program should properly handle hyphenated names, such as Mary-Jo.

package com.codegym.task.task19.task1921; import java.io.*; import java.text.SimpleDateFormat; import java.util.*; public class Solution { public static final List<Person> PEOPLE = new ArrayList<>(); public static void main(String[] args) throws IOException { FileReader fileReader = new FileReader(args[0]); BufferedReader reader = new BufferedReader(fileReader); fileReader.close(); String name = ""; String numbers = ""; while(reader.ready()){ String data = reader.readLine(); name = data.replaceAll("[^A-Za-z- ]", ""); name = name.trim(); numbers = data.replaceAll("[^\\d. ]", ""); numbers = numbers.trim(); String [] temp = numbers.split(" "); Date date = new Date(numbers); //SimpleDateFormat sdf = new SimpleDateFormat("MM DD YYYY"); Person person = new Person(name, date); PEOPLE.add(person); } reader.close(); } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

shovan

Level 22 , Kolkata, india

18 January 2020, 07:14

try this:

import java.util.*;
import java.io.*;
import java.text.*;

/*
John Johnson

*/

public class Solution {
    public static final List<Person> PEOPLE = new ArrayList<>();

    public static void main(String[] args) throws Exception {
        String[] personData;
        SimpleDateFormat simpleDateFormat = new SimpleDateFormat("MM dd yyyy");
        Date birthDate = null;
        BufferedReader reader = new BufferedReader(new FileReader(args[0]));
        while (reader.ready()) {
            String name = "";
            personData = reader.readLine().split(" ");
            birthDate = simpleDateFormat.parse(personData[personData.length-3] + " " + personData[personData.length-2] + " " + personData[personData.length-1]);
            for (int i = 0; i < personData.length-3; i++) {
                name = name + personData[i] + " ";
            }
            name = name.trim();
            PEOPLE.add(new Person(name, birthDate));
        }
        reader.close();
    }
}

Roman

Level 41

7 October 2019, 12:31

1) Did you check what you pass to the constructor in this case?

Date date = new Date(numbers);

use SimpleDateFormat, but read documentation about it first "MM DD YYYY" - isn't correct 2) Close the streams in the end of code.