What's wrong? It's worked at previosly task.

Question about the task

Archived

public class Solution {
    public static void main(String[] args) throws Exception {
       Scanner scan = new Scanner(System.in);
	        ArrayList <String> strings = new ArrayList<String>();
	            strings.add(scan.nextLine());
		        strings.add(scan.nextLine());
		        strings.add(scan.nextLine());
		        strings.add(scan.nextLine());
		        strings.add(scan.nextLine());

		        int min = 0;

		        for (int i = 0; i < strings.size()-1; i++) {
		            if (strings.get(i).length() > strings.get(i+1).length()) {
		            	min = i+1;
		            }
		        }

		        for (int i = 0; i < strings.size(); i++) {
		        	if (strings.get(i).length() == strings.get(min).length()) {
		        		System.out.println(strings.get(i));
		        	}
		        }
	    }
	}

1. Create a list of strings.
2. Read 5 strings from the keyboard and add them to the list.
3. Using a loop, find the shortest string in the list.
4. Display the string.
5. If there is more than one, display each on a new line.

Requirements:

Declare a string list variable and immediately initialize it.
The program should read 5 strings from the keyboard and write them to the list.
The program should display the shortest string.
If several strings are the shortest, then you need to display each of them on a new line.

package com.codegym.task.task07.task0709; import java.io.BufferedReader; import java.io.InputStreamReader; import java.util.ArrayList; import java.util.Scanner; /* Expressing ourselves more concisely */ public class Solution { public static void main(String[] args) throws Exception { Scanner scan = new Scanner(System.in); ArrayList <String> strings = new ArrayList<String>(); strings.add(scan.nextLine()); strings.add(scan.nextLine()); strings.add(scan.nextLine()); strings.add(scan.nextLine()); strings.add(scan.nextLine()); int min = 0; for (int i = 0; i < strings.size()-1; i++) { if (strings.get(i).length() > strings.get(i+1).length()) { min = i+1; } } for (int i = 0; i < strings.size(); i++) { if (strings.get(i).length() == strings.get(min).length()) { System.out.println(strings.get(i)); } } } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Brandon Horvatic

Level 27 , Johannesburg, South Africa

24 September 2019, 19:01

In line 26, you are comparing the first string to the second string and if the second string is shorter, min = i + 1, so the position of the second string. What happens if out of all the strings, the first one is the shortest, then min would stay 0. Set min to equal strings.get(0).length. Also, you are setting min to i + 1. So if the string is "hello", which is 5 char long, but it is in position 2 in strings, min will = 3 (1 + i(2)). So change line 27 to

min = strings.get(i).length;

Then make line 32

<
if (strings.get(i).length() == min) {

Brandon Horvatic

Level 27 , Johannesburg, South Africa

24 September 2019, 19:02

Its also quicker to use a loop to input data into the strings array, try

for(int i = 0; i < 5; i++) {
            strings.add(sc.nextLine());
        }

Сильвестр Сергеев

Level 14 , Kharkiv, Ukraine

25 September 2019, 10:02

Thanks for you respond. I use min variable for get index of value with minimum length. At line 23 i set min = 0, its means what a default index of minimum value = 0, it's first element at "strings".