Where I am wrong with that code, or is this bug?

Question about the task

2048 (part 8)

Java Multithreading, Level 10, Lesson 15

Archived

"The Model class's canMove method must be implemented in accordance with the task conditions." In my code in Model class canMove() function: Firstly, check if there are at least one empty tile. If true, movement can be made. Else, do copy of current state of board, next check if in movement to left, right etc. board was changed. If yes then movement was possible, so assign previous value of changed board and return true. If nothing of this returned true, return false. In Main I assigned values that I am sure canMove should return false because I copied them from 2048 game (now I know I could do it faster but nvm) Any thoughts? PS: In this code methods left, right, up, down was changed to return boolean, and return true if the board was changed.

The model is almost ready! Let's add a couple more simple methods and start implementing the controller.

Our model lacks a way to get the game board in order to pass it to the view for rendering, as well as a method that can determine whether a move is possible in the current position.

For its part, the controller will be mainly used to handle user input from the keyboard, so we'll make it a child of the KeyAdapter class.

We're going to need private model and view fields of the appropriate types, as well as getGameTiles and getScore methods that return the corresponding properties of the model.

Breaking it into simple steps:
1. Add a getter for the gameTiles field to the Model class.
2. Add to the Model class a canMove method that returns true if a move that changes the state of the game board is possible given the current position. Otherwise, it should return false.
3. Make the Controller class a child of the KeyAdapter class.
4. Add to the Controller class a getGameTiles method that calls the same method on the model.
5. Add to the Controller class a getScore method that returns the current score (model.score).

Requirements:

The Model class must implement a correct getter for the gameTiles field.
The Model class's canMove method must be implemented in accordance with the task conditions.
The Controller class must be a child of the KeyAdapter class.
The getGameTiles method in the Controller class must return the result of calling the getGameTiles method on the model.
The getScore method in the Controller class must return the model's score field.

package com.codegym.task.task35.task3513; import java.util.Arrays; public class Main { public static void main(String[] args) { Model model = new Model(); Tile[][] tiles = {{new Tile(2), new Tile(8), new Tile(4), new Tile(2)}, {new Tile(8), new Tile(4), new Tile(8), new Tile(16)}, {new Tile(2), new Tile(128), new Tile(16), new Tile(2)}, {new Tile(4), new Tile(16), new Tile(4), new Tile(16)}}; model.setGameTiles(tiles); for (int i = 0; i < tiles.length; i++) { for (int j = 0; j < tiles[0].length; j++) { System.out.print(tiles[i][j].value + " "); } System.out.println(); } System.out.println(); System.out.println(model.canMove()); System.out.println(); for (int i = 0; i < tiles.length; i++) { for (int j = 0; j < tiles[0].length; j++) { System.out.print(tiles[i][j].value + " "); } System.out.println(); } } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Azja

Level 32 , Krakow, Poland

25 September 2019, 15:30

solution

It passed with that, but what is wrong with code from above?

public boolean canMove()
    {
        for (int i = 0; i < gameTiles.length; i++)
        {
            for (int j = 0; j < gameTiles[i].length; j++)
            {
                if (j != gameTiles[i].length - 1)
                {
                    if (gameTiles[i][j].value == gameTiles[i][j + 1].value)
                    {
                        return true;
                    }

                    if (gameTiles[i][j].value == 0 && gameTiles[i][j + 1].value != 0)
                    {
                        return true;
                    }
                }

                if (i != gameTiles.length - 1)
                {
                    if (gameTiles[i][j].value == gameTiles[i + 1][j].value)
                    {
                        return true;
                    }

                    if (gameTiles[i][j].value == 0 && gameTiles[i + 1][j].value != 0)
                    {
                        return true;
                    }
                }
            }
        }
        return false;
    }

Tony Roy

Level 41 , Victorville, United States

13 May 2020, 12:57

Same question as Azja. I had multiple variations on that strategy (which seemed like they should be good). After 20 tries, reverted to this code which passes.

Isma

Level 41 , Madrid, Spain

13 July 2021, 09:33

The point here is that a move is possible if 1. There is a 0 tile on board, so you can consolidate tiles (getEmptyTiles) 2. There is not empty tiles on board but you have two neighbour tiles with the same value so you can perform a merge operation. This code works because you check this two cases.