Requirements 2, 3 and 5 keep failing.

Question about the task

Resolved

So far I've built this thing in 3 different ways, and I keep failing these requirements. The output seems to be correct though. Am I missing something?

package com.codegym.task.task06.task0606;

import java.io.*;

/*
Even and odd digits

*/

public class Solution {

    public static BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));


    public static int even = 0;
    public static int odd = 0;

    public static void main(String[] args) throws IOException {
        String input = reader.readLine();
        String[] inputAsArray = input.split("");

        for (int i = 0; i <= (inputAsArray.length - 1); i++) {
            if (!inputAsArray[i].equals("-")) {
                int digit = Integer.parseInt(inputAsArray[i]);
                if (digit % 2 == 0) {
                    even++;
                } else {
                    odd++;
                }
            }
        }



        System.out.println("Even: " + even + " Odd: " + odd);
    }

}

Use the keyboard to enter a positive number. Determine the number of even digits and odd digits in the entered number.
If a number is divisible by 2 without a remainder (i.e. the remainder is zero), then it is even.
And we'll increase the even digit counter (static variable even) by 1.
Otherwise, the number is odd, so we'll increase the odd digit counter (static variable odd).
Display the following message: "Even: a Odd: b", where a is the number of even digits and b is the number of odd digits.

Example for 4445:
Even: 3 Odd: 1

Requirements:

The program must read data from the keyboard.
The main method should calculate how many even digits are in the entered number and then write this number to the variable even.
The main method should calculate how many odd digits are in the entered number and then write this number to the variable odd.
The program should display text on the screen.
The displayed text must match the task conditions.

package com.codegym.task.task06.task0606; import java.io.*; /* Even and odd digits */ public class Solution { public static BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); public static int even = 0; public static int odd = 0; public static void main(String[] args) throws IOException { String input = reader.readLine(); String[] inputAsArray = input.split(""); for (int i = 0; i <= (inputAsArray.length - 1); i++) { if (!inputAsArray[i].equals("-")) { int digit = Integer.parseInt(inputAsArray[i]); if (digit % 2 == 0) { even = (even + 1); } else { odd = (odd + 1); } } } int a = even; int b = odd; System.out.println("Even: " + a + " Odd: " + b); } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Girish Patel

Level 8 , Hyderabad, India

9 October 2019, 18:21

In your code need to do all things in main() method only. So according to mine if you got it then mark it as a solution or you are free to ask any questions,

public class Solution {
    public static int odd;
    public static int even;

    public static void main(String[] args) throws IOException {
        BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));

        int a= Integer.parseInt(reader.readLine());

        while (a >0) {

            if (a%2 == 0) {
                even ++;
            } else {
                odd ++;
            }
            a/=10;
        }
        System.out.println("Even: "+even+" Odd: "+odd);
    }
}

Guadalupe Gagnon

Level 37 , Tampa, United States

3 October 2019, 16:26

Writing code in places not specified by the task will typically fail a bunch of the points. At line 12:

public static BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));

This is written in the class space, but the task wants you to write code in the main method space. Try removing this line of code and putting it inside the main method space instead.

Maarten Bakker

Level 13 , Sint-Oedenrode, Netherlands

3 October 2019, 19:07

Thank you!!! It's very frustrating when the errors given back are not the problem at all. Good job spotting the real bug.

Guadalupe Gagnon

Level 37 , Tampa, United States

3 October 2019, 19:32

Its really not a bug per say, though it generally is poor practice to use static variables where you do not need to in the real world. However a lot of these tasks can be thrown off by getting "creative" in your coding. I had to learn this myself and spent many hours i shouldn't have on simple tasks for similar things. Just remember to keep things simple and try to do exactly what is being asked. Good luck!