What is wrong? The code gives expected result but do not pass the test

Question about the task

Under discussion

Please, could somebody check what I am missing here? The code gives result as in the example but do not pass the testing :(

Read from the console the name of a file containing HTML.

Example:
Info about Leela Leela Turanga
Supergirl

The main method's first parameter is a tag name. For example, "span".
Display all tags that match the specified tag.
The order should match their order in the file, each tag on a new line.
The number of spaces, newline characters (\n), or carriage returns (\r) does not affect the result.
The file does not have a CDATA tag. Each opening tag has a separate closing tag, and there are no self-closing tags.
Tags may have nested tags.

Example output:
Leela Turanga Leela Turanga Super girl

Tag templates:
<tag>text1</tag> <tag text2>text1</tag> <tag text2>text1</tag>

text1 and text2 can be empty

Requirements:

The program must read the file name from the console (use BufferedReader).
The BufferedReader used for reading input from the console must be closed after use.
The program must read the file's contents (use FileReader).
The file input stream (FileReader) must be closed.
The program must write to the console all the tags that match the tag specified by the argument passed to the main method.

package com.codegym.task.task19.task1918; import java.io.*; import java.util.*; /* Introducing tags Leela TurangaSupergirl Info about Leela @ xml:lang="en" lang="en"> @>Leela Turanga $ $ @>Super $ @>girl $ Leela Turanga Leela Turanga Super girl */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); BufferedReader fileReader = new BufferedReader(new FileReader(reader.readLine())); reader.close(); StringBuilder stringBuilder = new StringBuilder(); while(fileReader.ready()) { stringBuilder.append(fileReader.readLine()); } String[] split = stringBuilder.toString().replaceAll("\n", "").replaceAll("\r", "").split("<"); String openingtag = "<" + args[0]; String closingtag = "</" + args[0] + ">"; ArrayList<String> fileContent = new ArrayList<String>(); for(int i=0; i<split.length; i++){ String temp = "<" + split[i]; fileContent.add(temp); // System.out.println("ADDED TEMP : " + temp); } int openedTagCounter = 0; //how many opened tags there are int nestedTagCounter = 0; // where the nested tag is located String toPrint = ""; boolean opened = false; for(int i = 0; i < fileContent.size(); i++){ // System.out.println("CHECKING: " + fileContent.get(i)); if(fileContent.get(i).contains(openingtag)){ opened = true; //to check if there was an opening tag toPrint += fileContent.get(i); if((openedTagCounter > 0) && (nestedTagCounter == 0)) { nestedTagCounter = i; // to get back to the index of first nested tag } openedTagCounter++; // System.out.println("TO PRINT OPEN TAG : " + toPrint); } else if(fileContent.get(i).contains(closingtag) && opened){ //chceking only if there was an opening tag, used in case of nested tags toPrint += fileContent.get(i); openedTagCounter--; // System.out.println("TO PRINT CLOSE TAG : " + toPrint); } else if(!(fileContent.get(i).contains(openingtag)) && (openedTagCounter > 0)){ toPrint += fileContent.get(i); //adding things like etc. // System.out.println("TO PRINT INSIDE : " + toPrint); } if((openedTagCounter == 0) && opened){ // System.out.println("------------- " + toPrint); System.out.println(toPrint); toPrint = ""; opened = false; if(nestedTagCounter !=0) { i = nestedTagCounter - 1; nestedTagCounter = 0; } } } // int startindex; // int endindex; // int tofind; // // while(fileContent.size() > 0) { // int t=0; // for(int i=0; i<fileContent.size(); i++) { // if(fileContent.get(i).contains("阿")) { // t = i; // break; // } // } // for(int i=0; i<t; i++) { // fileContent.remove(0); // } // // startindex = 0; // tofind = 0; // endindex = 0; // // for(int i=1; i<fileContent.size(); i++) { // if(fileContent.get(i).contains("阿")) tofind++; // if(fileContent.get(i).equals("不")) { // if(tofind != 0) tofind--; // else if(tofind == 0) { // endindex = i; // break; // } // } // } // // StringBuilder sbb = new StringBuilder(); // // for(int i=startindex; i<=endindex; i++) { // sbb.append(fileContent.get(i)); // } // // System.out.println(sbb.toString().replaceAll("阿",openingtag).replaceAll("不",closingtag)); // // fileContent.remove(0); // } fileReader.close(); } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

7 October 2019, 15:26

useful

As far as i can tell your program works as expected. I am thinking that, maybe, when you have an open tag that is followed immediately by a new line character, then the rest, that there should be a space between the tag and the continuation. For example, if you changed args[0] to "tag" and used the text inside "tag templates" in the instruction, I get the output of: .tag.text1./tag. .tag text2.text1./tag. .tagtext2.text1./tag. ↑ there is no space here, i'm thinking there should be (i edited out the angle brackets and used periods instead because this text box is set to read HTML and wont display angle brackets when posted) Try that out and see if you pass.

Anonymous #10438472

Level 40

7 October 2019, 18:12

Thank you for pointing out this issue - I think I fixed it but still I cannot pass the testing. I changed line 39 to add space at the end of each line - what solves problem with missing space in place you showed me:

stringBuilder.append(fileReader.readLine() + " ");

then when I am building String toPrint I trimmed the additional space so now my output now is : .tag.text1./tag. .tag text2.text1./tag. .tag text2.text1./tag. I hope I didn't mess with the spaces - the output looks ok. Do you have any idea what else could be wrong?

Guadalupe Gagnon

Level 37 , Tampa, United States

7 October 2019, 18:58

I wasn't sure if that was it or not. These tasks can be extremely frustrating when verification is failing but no indication is given as to why. I have written suggestions to Codegym that they provide more example inputs and outputs to the tasks to help avoid the confusion, but they have not implemented it (yet?). I suggest looking at other help posts for this task to see if anything is helpful.

Guadalupe Gagnon

Level 37 , Tampa, United States

7 October 2019, 19:32

One difference from my code to your code is that mine I does not remove carriage returns and new lines. When i run mine with the example input, the one with 'tag', it outputs with the new line character that is in there. My output is: .text1. . text2>text1. . text2>text1.