What am I doing wrong?

Question about the task

Under discussion

Hey, I was trying to count the neighbours around the mine, but I cannot get it to work. Could someone help me?

Now let's count the mines in adjacent cells. To do this, we'll add a field to each cell of the matrix, which will be responsible for the number of mined neighbors. First, we find all the neighbors, and then we count how many of them are mined.

To get the list of neighbors, you now have the getNeighbors() method, which has one GameObject (cell) parameter.

Your task is to, in a separate method, count the number of mined neighbors for each cell in gameField and assign this value to the appropriate field of the cell.

Although your work is not visible (you started program to see what happens, right?), it is very important to future steps.

Requirements:

The GameObject class must have a public int countMineNeighbors field.
The MinesweeperGame class must have a private void countMineNeighbors() method.
The countMineNeighbors() method should, for each non-mined cell in the gameField matrix, count the number of adjacent mined cells and assign this value to the countMineNeighbors field.
The countMineNeighbors() method should use the getNeighbors(GameObject gameObject) method.
In the createGame() method, after all the elements of the gameField matrix are created, the countMineNeighbors() method must be called.

package com.codegym.games.minesweeper; import com.codegym.engine.cell.*; import java.util.*; public class MinesweeperGame extends Game { private static final int SIDE = 9; public void initialize(){ setScreenSize(SIDE, SIDE); createGame(); } private GameObject[][] gameField = new GameObject[SIDE][SIDE]; private int countMinesOnField = 0; private void createGame(){ for(int i = 0; i < SIDE; i++) for(int j = 0; j < SIDE; j++){ boolean mine = false; if (i == getRandomNumber(10) || j == getRandomNumber(10)){ mine = true; countMinesOnField++; } else mine = false; gameField[i][j] = new GameObject(j, i, mine); setCellColor(i, j, Color.ORANGE); } countMineNeighbors(); } private void countMineNeighbors(){ for (int x = 0; x < SIDE; x++) for(int y = 0; y < SIDE; y++) if(!gameField[y][x].isMine) for(GameObject g:getNeighbors(gameField[y][x])){ if(g.isMine) gameField[y][x].countMineNeighbors++; } } private ArrayList<GameObject> getNeighbors(GameObject gameObject) { ArrayList<GameObject> neighbors = new ArrayList<GameObject>(); int m = gameObject.y; int n = gameObject.x; for(int x = m - 1; x < m + 1; x++) for(int y = n - 1; y < n + 1; y++){ if(x < 1 || x > SIDE) break; if(y < 1 || y > SIDE) break; //if(gameField[y][x] == gameObject) // continue; neighbors.add(gameField[y][x]); } return neighbors; } }

Comments (1)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

9 October 2019, 15:09

#1 It looks like lines 49 through 58 have bad logic. First your outer loop should be y and your inner loop x #2 (int x = m - 1; x < m + 1; x++) lets say that m = 3, then x will start with a value of 2, the next loop cycle will be x will equal 3, then the next loop cycle will not happen because x would equal 4 which is not less than m + 1 (4). This only checks 2 lines and not 3. #3 After fixing both above x| x x x| x x x| x x Lets say that you are testing the middle x, and on the left is outside the game board. The very first check will be the top left corner 'x' and your break statements will break the inner loop, the next check will be the middle left 'x' and once again the inner loop will break, then the third check will be the bottom left x and your loop will break and the method exits without adding a single object. #4 You need to make sure that you do not check the original square for the passed in gameObject