Requirements should be passing, it is doing what it's supposed to do

Question about the task

Longest string

Java Syntax, Level 7, Lesson 6

Archived

Even using the web compiler, and the two long words are displayed, the tasks is still not passing. Any ideas? Thanks

1. Initialize the list of strings.
2. Read 5 strings from the keyboard and add them to this list.
3. Using a loop, find the longest string in the list.
4. Display the string. If there is more than one, display each on a new line.

Requirements:

In the main method, initialize the Solution class's existing strings field to a new ArrayList<>.
The program should read 5 strings from the keyboard and write them to the list of strings.
The program should display the longest string.
If several strings qualify as the longest, then you need to display each of them on a new line.

package com.codegym.task.task07.task0708; import java.io.BufferedReader; import java.io.InputStreamReader; import java.util.ArrayList; import java.util.List; /* Longest string */ public class Solution { private static List<String> strings = new ArrayList<>(); public static void main(String[] args) throws Exception { //write your code here BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int longestString = 0; for (int i = 0; i < 5; i++) { strings.add(reader.readLine()); } for (int i = 0; i < strings.size(); i++) { if (strings.get(i).length() > longestString) longestString = strings.get(i).length(); } for (int i = 0; i < strings.size(); i++) { if (strings.get(i).length() == longestString) System.out.println(strings.get(i)); } } }

Comments (7)

Popular
New
Old

You must be signed in to leave a comment

Miha Čelešnik

Level 9 , Ilirska Bistrica, Slovenia

17 November 2019, 10:32

The point of whole thing is not to dig up workaround path by guessing. I understand implementing sempiler is no easy task, but if there is the issue of location of declared variable, than this should be stated in instructions. Btw Mr. Gagnon your solution does not work for me.

James Mackenzie

Level 7 , Victoria, Australia

18 October 2019, 00:27

try a second array to store strings of equal size. then output list at end. try assign the first index to the int variable to help evaluate size comparison with the rest. trying not to give you the code rather some hints as to another way of thinking about the problem.

Guadalupe Gagnon

Level 37 , Tampa, United States

16 October 2019, 17:27

Try this:

public class Solution {
    private static List<String> strings;

    public static void main(String[] args) throws Exception {
        strings = new ArrayList<>();
        // rest of code

Tejendra Pal Singh

Level 10 , Lucknow, India

18 October 2019, 08:07

it worked but how? can you please explain

Guadalupe Gagnon

Level 37 , Tampa, United States

18 October 2019, 13:59

First it is important to understand that the way you had did it originally, in the real world, is perfectly acceptable and common practice. Now the thing with these tasks is that they can be very strict in what you can do and what you can not do to pass verification, and these strict rules are not always spelled out in the conditions/requirements. The only hint that I had is that the starting code says where to write:

public class Solution {
    private static List<String> strings;

    public static void main(String[] args) throws Exception {
        //write your code here
    }
}

When they coded the verification for this task, they only coded all the checks to only check what is in the main method (though they don't say this in the requirements). You will be pulling your hair out on some of the tasks later on, because sometimes they want you to code in other places and sometimes they do not. A thing that I used to do when I was failing tasks and couldn't figure out why: I would copy + paste my code into note pad or something similar, reset the task so I could see the starting code and if I had missed something like where it said to put my code, then paste my code back in and make changes where necessary. When all else fails you can ask for help too.

Facundo Villarroel

Level 20 , Berlin, Germany

3 November 2019, 17:34

Yup, this was the problem. Thank you very much

yehuda b

Level 23 , Beersheba, Israel

12 January 2020, 13:22

Wow! had the same problem! thanks for elaborating, guess algorithms aren't human...