The task doesn't compile on server (but it does on my machine)

Question about the task

Resolved

So when I try to submit this code I get the following error: Error in com/codegym/task/task31/task3105/Solution.java on line 34 cannot find symbol symbol: method readAllBytes() location: variable zipIs of type java.util.zip.ZipInputStream Anyone an idea what I'm doing wrong?

The main method accepts a list of arguments.
The first argument is the full path to the fileName file.
The second argument is the path to a ZIP file.
Add the fileName file to the archive inside the "new" directory.
If the archive already has a file with the same name in the "new" directory, then replace it.

Example input:
C:/result.mp3 C:/pathToTest/test.zip

Files inside test.zip:
a.txt b.txt

After running Solution.main, the test.zip archive must contain the following:
new/result.mp3
a.txt b.txt

Hint: you need to first save the contents of all of the zip entries somewhere,
and then write all the entities together with the added file to the archive.
Don't use the file system.

Requirements:

In the main method, create a ZipInputStream for the archive (main's second argument). You need to read all of its contents.
In the main method, create a ZipOutputStream for the archive (main's second argument).
You need to write the contents of the file passed to main as the first argument to the ZipOutputStream.
You need to write all of the other content read from the ZipInputStream to the ZipOutputStream.
The archive streams must be closed.

package com.codegym.task.task31.task3105; import java.io.*; import java.nio.file.Files; import java.nio.file.Path; import java.nio.file.Paths; import java.util.HashMap; import java.util.Map; import java.util.zip.ZipEntry; import java.util.zip.ZipInputStream; import java.util.zip.ZipOutputStream; public class Solution { public static void main(String[] args) throws IOException { String fileToBeAdded = args[0]; String zipArchive = args[1]; Map<String, Path> savedFiles = saveFilesInMap(zipArchive); createArchive(savedFiles, fileToBeAdded, zipArchive); } public static Map<String, Path> saveFilesInMap(String archive) throws IOException { Map<String, Path> map = new HashMap<>(); FileInputStream fis = new FileInputStream(archive); ZipInputStream zipIs = new ZipInputStream(fis); ZipEntry ze; while ((ze = zipIs.getNextEntry()) != null) { Path tempFile = Files.createTempFile("",""); Files.write(tempFile, zipIs.readAllBytes()); map.put(ze.getName(), tempFile); } zipIs.close(); fis.close(); return map; } public static void createArchive(Map<String, Path> files, String fileToBeAdded, String archiveName) throws IOException { FileOutputStream fos = new FileOutputStream(archiveName); ZipOutputStream zos = new ZipOutputStream(fos); files.forEach((name, path) -> { try { zos.putNextEntry(new ZipEntry(name)); Files.copy(path, zos); } catch (IOException e) { e.printStackTrace(); } }); zos.putNextEntry(new ZipEntry("new/" + fileToBeAdded)); Files.copy(Paths.get(fileToBeAdded), zos); zos.close(); fos.close(); } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

17 October 2019, 16:05

solution

readAllBytes() is a perfectly acceptable method. The problem is that codegym uses an older build of java that does not have/support that method. You will need to work around this. Try something like this:

while ((ze = zipIs.getNextEntry()) != null) {
            byte[] buffer = new byte[1024];
            ByteArrayOutputStream builder = new ByteArrayOutputStream();
            int end;
            while((end = zipIs.read(buffer)) > 0){
                builder.write(buffer, 0, end);
            }
            Path tempFile = Files.createTempFile("","");
            Files.write(tempFile, builder.toByteArray());
            map.put(ze.getName(), tempFile);
        }

Guadalupe Gagnon

Level 37 , Tampa, United States

17 October 2019, 16:12

useful

I haven't tested this code so it may not pass verification, but you should be able to figure it out from here. Basically create a buffer array (line 2). This isn't going to big enough in most cases, but zipInputStream doesnt have a method like .available() that give the exact size. This means that you need a place to store each buffer read, hence line 3 with the ByteArrayOutputStream (BAOS). So lines 4-7 do the actual reading, as long as there is still data, and stores it in the BAOS. The .read() method will return -1 when no data is read in, which will break the loop. Then you have all the bytes and you can use Files.write() like before, but with the BAOS of all the bytes.

Han

Level 24 , Netherlands

18 October 2019, 06:28

Thank you for your explanation! This workaround does compile! Now onto the next hurdle: Now the verification fails for: 3.You need to write the contents of the file passed to main as the first argument to the ZipOutputStream. 4.You need to write all of the other content read from the ZipInputStream to the ZipOutputStream. When I run this locally I get the zip archive just like in the example so I'm not sure what I'm doing wrong.

Guadalupe Gagnon

Level 37 , Tampa, United States

18 October 2019, 13:48

It looks like when you add the new file it gets added to the new file + the full path to the original file. So it looks like this in the zip archive: C:/pathToTest/test.zip/new/user/local/desktop/temp/fileTobBeAdded.txt where it should look like this: C:/pathToTest/test.zip/new/fileTobBeAdded.txt Its an easy fix. Convert the string fileToBeAdded to a Path, then in the putNextEntry method pass the arguement Path.GetFileName() instead of the full string. I do not see anything else wrong with your code, though I cannot confirm if it will validate or not.