What's wrong in my code? Someone please help me!!!

Question about the task

Task about algorithms

Java Syntax, Level 5, Lesson 12

Archived

what's the issue here?

Write a program that:
1. reads a number N (must be greater than 0) from the console
2. reads N numbers from the console
3. Displays the maximum of the N entered numbers.

Requirements:

The program should read the numbers from the keyboard.
The program must display a number on the screen.
The class must have a public static void main method.
Don't add new methods to the Solution class.
The program should display the maximum of the N entered numbers.
The program should not display anything if N is less than or equal to 0.

package com.codegym.task.task05.task0532; import java.io.*; /* Task about algorithms */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int n = Integer.parseInt(reader.readLine()); int max = 0; int res = 0, neg = -1; while(n > 0) { int a = Integer.parseInt(reader.readLine()); if( a < 0 ) { if(a > neg) neg = a; } if(a > res ) { res = a; } n--; } if(res > 0) System.out.println(res); else System.out.println(neg); } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

Abhirami

Level 17 , Bangalore, India

23 October 2019, 06:52

Got it. Thank you!

Mike McKenna

Level 25 , Wilmington, United States

22 October 2019, 21:14

Hi, this task took quite a bit of work to complete . hard to find proper way to write the code . i used if while and if else . int max = Integer.MIN_VALUE; on line 14 vs int max = 0; . u will see improvement . also if u remove the negative # 's . line 18/19 ">" have to agree . G G offers great advice to follow .

Guadalupe Gagnon

Level 37 , Tampa, United States

22 October 2019, 18:48

I see what you did but I would argue that you are over complicating a simple task. If you set line 14 to the very lowest number that an integer can hold then every number entered will be higher (or at least be the same as) that number. Don't worry, you don't need to run to google to remember that the lowest possible number an int can hold is -2147483648 (i did google that). Change line 14 to this:

int max = Integer.MIN_VALUE;

This is very easy to remember and there is also a MAX_VALUE. So rewrite the rest of you code only using max like this:

// {inside loop}
// get an int
// check if is greater than the current max, change it if so
//{end loop}
//print max

Guadalupe Gagnon

Level 37 , Tampa, United States

22 October 2019, 18:55

Now if you want to fix this code then the problem is that this code does not account if the user actually enters 0. If the user enters 0 and negative numbers, then 0 would be the max number entered, but the line at 26 says if res equals 0 then output neg. Fix this and your code will pass.