What wrong?? 3&4 failed

Question about the task

Splitting a file

Java Core, Level 8, Lesson 5

Under discussion

Help please, i checked, it is work but don't pass

Read 3 file names from the console: file1, file2, file3.
Split file1 as follows:
Write the first half of its bytes to file2,and write the second half of its bytes to file3.
If the number of bytes in file1 is odd, then file2 should contain the larger half.
Close the streams.

Requirements:

The program should read a file name three times from the console.
Use FileInputStream to read from a file, and use FileOutputStream to write to files.
The first half of the bytes in the first file must be written to the second file.
The second half of the bytes in the first file must be written to the third file.
The FileInputStream and FileOutputStream must be closed.

package com.codegym.task.task18.task1808; /* Splitting a file */ import java.io.*; public class Solution { public static void main(String[] args) { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); try { String fileName1 = reader.readLine(); String fileName2 = reader.readLine(); String fileName3 = reader.readLine(); reader.close(); FileInputStream fileInput1 = new FileInputStream(fileName1); FileOutputStream fileOutput2 = new FileOutputStream(fileName2); FileOutputStream fileOutput3 = new FileOutputStream(fileName3); File file = new File(fileName1); byte [] buffer; if(file.length()%2==0){ buffer=new byte[(int) (file.length()/2)]; }else { buffer=new byte[(int) (file.length()/2)+1]; } fileInput1.read(buffer); fileOutput2.write(buffer); fileOutput2.close(); int count = fileInput1.read(buffer); fileInput1.close(); fileOutput3.write(buffer,0,count); fileOutput3.close(); } catch (IOException e) { e.printStackTrace(); } } }

Comments (4)

Popular
New
Old

You must be signed in to leave a comment

KIN SOCHEAT

Level 34 , Phnom Penh, Cambogia

25 October 2019, 15:37

i pass with this if(fis.available() %2 != 0){ // fos2.write(Buffe,0,halfCount ); // fos3.write(Buffe,halfCount ,halfCount ); }else { fos2.write(Buffe,0,halfCount + restCount); fos3.write(Buffe,halfCount + restCount, halfCount ); }

KIN SOCHEAT

Level 34 , Phnom Penh, Cambogia

25 October 2019, 15:36

I think you should write in if if(file.length()%2==0){ buffer=new byte[(int) (file.length()/2)]; fileOutput2.write(buffer); fileOutput3.write(buffer); }else { buffer=new byte[(int) (file.length()/2)+1]; fileOutput2.write(buffer); fileOutput3.write(buffer); }

Петр Зинченко

Level 19 , Kharkiv, Ukraine

24 October 2019, 08:38

passed with replacement

if(fileInput1.available()%2==0){
                buffer=new byte[(int) (fileInput1.available()/2)];
            }else {
                buffer=new byte[(int) (fileInput1.available()/2+1)];
            }

don't understand why didn't pass earlier. HELP!!

Guadalupe Gagnon

Level 37 , Tampa, United States

24 October 2019, 18:12

useful

I don't know exactly why this would be a problem because file.length() will return the same number as fis.available(), however I do have a theory. I think that codegym creates proxies when testing code that hijack the inputstreams from your code and has it read from a determined cache instead of from a file. This most likely is so that any submitted code won't actually have full access to the underlying architecture at codegym. Now the problem comes in that there is no actual "file" in the location that they are testing so your code with file.length() will return 0 every time, while the hijacked proxy can determine the size of the cache. I do not know if this is the reason but it is a theory of mine. I have done a bunch of research on your problem through google and my own tests and have found no differences between .available() and .length().

try {
           String fileName =  ""; // point to a file on your computer

           FileInputStream fileInput1 = new FileInputStream(fileName);
           File file = new File(fileName);

           System.out.println(file.length());
           System.out.println(fileInput1.available());
           System.out.println(file.length()/2);
           System.out.println(fileInput1.available()/2);
           System.out.println((file.length()/2)+1);
           System.out.println((fileInput1.available()/2+1));
           fileInput1.close();
       } catch (IOException e) {
           e.printStackTrace();
       }

Here is the code i used. I have tried .txt, .jpg, .pdf, and .xlsx files and have found no variations.