Am i missing something?

Question about the task

Under discussion

The algorithm looks like it's sorting the array in descending order. But for some reason, even though the displayed numbers are the biggest five. It fails testing? Is the algorithm wrong? or maybe something else? Kindly let me have your answers. Thank you

Create an array of 20 numbers.
Populate it with numbers from the keyboard.
Display the five largest numbers.
Each value should be on a new line.

Requirements:

The program should display numbers on the screen.
The program should read values from the keyboard.
The Solution class must have two methods.
The sort() method should sort the array of numbers from highest to lowest.
The main() method should call the sort() method.
The program should display the five largest numbers in the array. Each value should be on a new line.

package com.codegym.task.task08.task0826; import java.io.BufferedReader; import java.io.InputStreamReader; /* Five winners */ public class Solution { public static void main(String[] args) throws Exception { BufferedReader reader = new BufferedReader(new InputStreamReader(System.in)); int[] array = new int[10]; for (int i = 0; i < array.length; i++) { array[i] = Integer.parseInt(reader.readLine()); } sort(array); System.out.println(array[0]); System.out.println(array[1]); System.out.println(array[2]); System.out.println(array[3]); System.out.println(array[4]); } public static void sort(int[] array) { //write your code here int temp; for (int i = 0; i < array.length; i++) { for (int j = i +1; j < array.length -1; j++) { if (array[i] < array[j+1]) { temp = array[i]; array[i] = array[j+1]; array[j+1] = temp; } } } } }

Comments (3)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

27 October 2019, 18:27

useful

The algorithm for sorting is incorrect. You will need to debug the code and find the errors. I suggest using placing a bunch of system.out.println() statements strategically through out the code to find out what is happening.

Robert Constantinescu

Level 25 , Bucharest, Romania

28 October 2019, 06:52

ok, thank you. The thing is that it outputed the first 5 biggest numbers

Guadalupe Gagnon

Level 37 , Tampa, United States

28 October 2019, 13:14

Not always though, if the sort algorithm is wrong then it can output the incorrect numbers. It may be helpful to change your main method to this while you test. You can input any combination of numbers in at line 3 for testing purposes. I left these 5 because the output will be incorrect:

public static void main(String[] args) throws Exception {
        //BufferedReader reader = new BufferedReader(new InputStreamReader(System.in));
        int[] array = {7,2,1,6,1};
        //for (int i = 0; i < array.length; i++) {
            //array[i] = Integer.parseInt(reader.readLine());
        //}

        sort(array);

        System.out.println(array[0]);
        System.out.println(array[1]);
        System.out.println(array[2]);
        System.out.println(array[3]);
        System.out.println(array[4]);
    }