All conditions are met?

Question about the task

Somehow average

Java Syntax, Level 4, Lesson 16

Under discussion

All conditions that are given to me are correct. Am I missing something? Thanks in advance!

package com.codegym.task.task04.task0441; /* Somehow average */ import java.io.*; public class Solution { public static void main(String[] args) throws Exception { //write your code here BufferedReader you = new BufferedReader(new InputStreamReader(System.in)); int a = Integer.parseInt(you.readLine()); int b = Integer.parseInt(you.readLine()); int c = Integer.parseInt(you.readLine()); a = 2; b = 4; c = 2; if (a < b && a > c){ System.out.println(a); } else if (a < c && a > b){ System.out.println(a); } else if (a < b && a < c && b == c){ System.out.println(a); } else if (a < c && b < c && a == b){ System.out.println(a); } else if (a < b && c < b && a == c){ System.out.println(a); } if (b < a && b > c){ System.out.println(b); } else if (b > a && b < c){ System.out.println(b); } else if (b < a && b < c && a == c){ System.out.println(b); } else if (b < a && b < c && b == c){ System.out.println(b); } else if (b < a && c < a && b == c){ System.out.println(b); } if ( c < a && c > b){ System.out.println(c); } else if ( c > a && c < b){ System.out.println(c); } else if ( c < a && c < b && a == b){ System.out.println(c); } if (a == b && b == c && c == a){ System.out.println(b); } } }

Comments (7)

Popular
New
Old

You must be signed in to leave a comment

Guadalupe Gagnon

Level 37 , Tampa, United States

28 October 2019, 15:43

#1 lines 20- 22 fail condition of user input only #2 I tried inputting with number 4,4,2 and it output 2. The correct answer is 4 I suggest first checking for equality. If any 2 numbers are the same then you can print any of the 2. After that you know that the numbers are not equal so then you can check for order:

if(any two numbers are equal) print one of those numbers
else{
   // these below can now safely be assumed that none of the numbers are equal

   if(a is middle) output a
   if(b is middle) output b
   if(c is middle) output c
}

Jimmy Phan

Level 7 , Atlanta, United States

28 October 2019, 16:57

I like that you checked for equality first. Any tips on how I can get better at If/If else statements? They are my weakness at the moment. I also was bit confused on what the program was asking me to do. I thought if two numbers were the same I should print the lowest number. Sorry.

Guadalupe Gagnon

Level 37 , Tampa, United States

28 October 2019, 17:13

I go to the help section a lot not only to help, but to see how other people solved problems. I have learned a lot of new ways of thinking and better solutions than I had come up with originally. This is definitely faster than trying to figure out the best way yourself. Just remember there are always 3 checks with booleans: 1) a > b 2) a < b 3) a == c (this one people forget about) Its best to create an outline of what you want to do first and try to figure out the best order, lets say you are trying to figure out which season a month between 1-12 falls into. You could solve it like this:

int month = // (a random number between 1-12)
if(month >= 1 && month <= 3) // winter
else if(month >= 4 && month <= 6) // spring
else if(month >= 7 && month <= 9) // summer
else if(month >= 10 && month <= 12) //fall

or you can solve it cleaner like this:

if(month <= 3) // winter
else if (month <= 6) // spring
else if (month <= 9) // summer
else // fall

The first example, if the number is between 10-12, there would be a total of 8 boolean checks just to figure out it is 'fall'. In the bottom example, there would only be 3 to do the same exact thing. Because if-else goes from one check to the next in order, and stops once it finds a 'true', you don't need to specifically check if the number falls between a range like in the first example. The second one sets a floor by checking for numbers of 3 or below, if that fails you know for a fact that month has to be greater than 3. You next check if it is less than or equal to six, if that fails you know that it is greater than 6. The same applies for the next check of 9, and if that fails then the number has to be in the range of fall so you can skip another boolean by just using else.

Guadalupe Gagnon

Level 37 , Tampa, United States

28 October 2019, 17:23

For this task specifically, this is how I would out line the solution:

if(/*check if a equals either b or c*/) //output a
else if(/*check if b equals c*/) //output b
// above checks for all cases of equality including if all three are equal
else{
   if(a > b){
      // we know nothing is equal and a is greater than b
      if(a < c)  // a > b and a < c -- a is the middle
      else{
          if(c > b) //a > b and a > c and c > b -- c is the middle
          else // a > b and a > c and c < b -- b is the middle
      }
   }else{
      // we know nothing is equal and a is less than b

        /* see if you can fill in the rest using my
        using lines 7-10 directly above */


   }
}

Jimmy Phan

Level 7 , Atlanta, United States

1 November 2019, 00:34

if (a == b || a == c){ System.out.println(a); } else if (b == c){ System.out.println(b); } else { if (a > b) { if (a < c) { System.out.println(a); } else { if (c > b) { System.out.println(c); } else { System.out.println(b); } } } } } } this is what I got so far lol. Though I did notice I wasn't able to print numbers such as (1,2,3).

Guadalupe Gagnon

Level 37 , Tampa, United States

1 November 2019, 03:46

if (a == b || a == c)
        System.out.println(a);
    else if (b == c)
        System.out.println(b);
    else if (a > b) {
        // a is greater than b
        if (a < c) System.out.println(a);
        else {
            if (c > b) System.out.println(c);
            else System.out.println(b);
        }
    } else {
        // a is less than b
        if (a > c) System.out.println(a);
        else {
            if (c > b) System.out.println(b);
            else System.out.println(c);
        }
    }

Guadalupe Gagnon

Level 37 , Tampa, United States

1 November 2019, 03:57

I should tell you that this is still a very long way to solve this problem. The simple way to solve this is to sort the 3 numbers (either ascending or descending, doesn't matter) then output the middle one. so if you input: 3, 1, 2 and sorted them you would have 1, 2, 3 in which case the middle number would be the answer. It works for any values you enter: enter - 1, 2, 1 then sort them you would get 1, 1, 2 and the middle is the answer enter 5, 5, 3 sort to 3, 5, 5 and the middle is the answer.