Hi guys, answer looks like is correct but still something not good

Question about the task

Resolved

*/ public class Solution { public static int min(int a, int b, int c) { if(a<=b && b<=c) if (a<=c) return a; else return b; else if(b<=a && a<=c) if(b<=c) return b; else return a; else if(c<=a && b<=a); if(c<=b) return c; else return b; }

package com.codegym.task.task02.task0216; /* Minimum of three numbers */ public class Solution { public static int min(int a, int b, int c) { if(a<=b && b<=c) if (a<=c) return a; else return b; else if(b<=a && a<=c) if(b<=c) return b; else return a; else if(c<=a && b<=a); if(c<=b) return c; else return b; } public static void main(String[] args) throws Exception { System.out.println(min(1, 2, 3)); System.out.println(min(-1, -2, -3)); System.out.println(min(3, 5, 3)); System.out.println(min(5, 5, 10)); } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Anthony Chalk

Level 30 , London, United Kingdom

31 October 2019, 09:41

Why do you have the second if/else condition each time? If a<= b and b<= c, by definition a <= c, you don't need to specify that. Also, attaching your code makes it easier to read and to see which conditions are nor being validated.

Guadalupe Gagnon

Level 37 , Tampa, United States

31 October 2019, 13:37

That is a good point that Anthony makes, the inner if statements are not necessary because you can already determine order with 2 boolean checks. The big problem with this code however is line 20. You will notice a little semi-colon at the end. This is going to end the else block one line above it and the line one below it will be a seperate check. Here is how your code properly indented, which easily shows how it works:

public static int min(int a, int b, int c) {
    if (a <= b && b <= c)
        if (a <= c)
            return a;
        else
            return b;
    else if (b <= a && a <= c)
        if (b <= c)
            return b;
        else
            return a;
    else if (c <= a && b <= a) ; // here ends entire if-else structure

    if (c <= b)
        return c;
    else
        return b;
}