Can somebody help me what's wrong with my code?

Question about the task

Factory method pattern

Java Core, Level 6, Lesson 13

Resolved

Last four conditions did not verify. Don1T understand why. Help, please! Thanks!

1. Take a careful look at the classes you have.
2. In separate files in the common package, create JpgReader, PngReader, and BmpReader classes that implement the ImageReader interface.
3. In a separate file in the main package, create the ImageReaderFactory class with one method.
3.1. Think about what it should be called.
3.2. Think about which modifiers this method should have.
4. This method should:
4.1. For each value in ImageTypes, return the appropriate Reader. For example, for
ImageTypes.JPG, return a JpgReader;
4.2. If an invalid argument is passed, then throw an exception:
IllegalArgumentException("Unknown image type").

Requirements:

Create a JpgReader class in the common package. It must implement the ImageReader interface.
Create a PngReader class in the common package. It must implement the ImageReader interface.
Create a BmpReader class in the common package. It must implement the ImageReader interface.
Create a public class named ImageReaderFactory.
Add a public static method getImageReader with an ImageTypes parameter to the ImageReaderFactory class.
The getImageReader method must create and return a suitable Reader.
The getImageReader method must throw an IllegalArgumentException if an invalid argument is passed.

package com.codegym.task.task16.task1631; import com.codegym.task.task16.task1631.common.ImageReader; import com.codegym.task.task16.task1631.common.ImageTypes; import com.codegym.task.task16.task1631.common.ImageReaderFactory; public class Solution { public static void main(String[] args) { ImageReader reader = ImageReaderFactory.getImageReader(ImageTypes.JPG); } }

Comments (2)

Popular
New
Old

You must be signed in to leave a comment

Angelika

Level 25 , Budapest, Hungary

31 October 2019, 20:42

I can see now, thanks! There was a mistake at Solution class too.

Guadalupe Gagnon

Level 37 , Tampa, United States

31 October 2019, 14:43

Line 1 of the ImageReaderFactory is incorrect. Take a look at line 1 of each other class and see if you can find the mistake.